[Qt] Failure to build with --no-inspector

[Lauro Moura Maranhao Neto]

QtWebKit fails to build with --no-inspector.

Output:

/home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp: In member function 'QUrl QQuickWebViewExperimental::remoteInspectorUrl() const':
/home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1334:17: error: 'WebInspectorServer' was not declared in this scope
In file included from /home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1953:0:
/home/lauro/dev/webkit/webkit/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1335:1: error: control reaches end of non-void function [-Werror=return-type]

[Lauro Moura Maranhao Neto]

Created attachment 158640 [details]
Add guards for inspector usage

[Jesus Sanchez-Palencia]

Comment on attachment 158640 [details]
Add guards for inspector usage

View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1339
> +    return QUrl();

What about outputting some sort of Warning message saying that this feature is not available due to build options or something like that?

[Jocelyn Turcotte]

Comment on attachment 158640 [details]
Add guards for inspector usage

View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:36
> +#if ENABLE(INSPECTOR)

It would be nice to use ENABLE(INSPECTOR_SERVER) to match with ::initInspectorServer in Source/WebKit2/UIProcess/qt/QtWebContext.cpp.
It might then not solve your build issue, if it doesn't you could define ENABLE_INSPECTOR_SERVER in Source/WebKit2/config.h conditionally to ENABLE_INSPECTOR being defined.

[Lauro Moura Maranhao Neto]

Created attachment 158874 [details]
Patch

INSPECTOR_SERVER is disabled by features.prf when INSPECTOR is disabled. Updated patch by replacing it in the guards.

[Lauro Moura Maranhao Neto]

(In reply to comment #2)
> (From update of attachment 158640 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158640&action=review
> 
> > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1339
> > +    return QUrl();
> 
> What about outputting some sort of Warning message saying that this feature is not available due to build options or something like that?

Something like qWarning("WebInspector support is disabled.")?

[WebKit Review Bot]

Comment on attachment 158874 [details]
Patch

Clearing flags on attachment: 158874

Committed r125859: <http://trac.webkit.org/changeset/125859>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.