FractionalLayoutBoxExtent and LayoutBox currently have a dependency on RenderStyle to resolve writing mode and directional. This breaks encapsulation and makes it hard to reuse the box classes.
Created attachment 158651 [details] Patch
s/directional/directionality/
Simon, any chance you could take a look at this change?
Ping?
Comment on attachment 158651 [details] Patch I think this is a fantastic change.
Comment on attachment 158651 [details] Patch Rejecting attachment 158651 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: at 3145 (offset 5 lines). Hunk #4 succeeded at 3306 (offset 5 lines). patching file Source/WebCore/rendering/RenderBox.h Hunk #1 succeeded at 234 (offset 4 lines). patching file Source/WebCore/rendering/style/RenderStyle.h Hunk #2 succeeded at 725 (offset 7 lines). patching file Source/WebCore/rendering/style/RenderStyleConstants.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13570324
Comment on attachment 158651 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158651&action=review Thanks for fixing this platform violation. > Source/WebCore/ChangeLog:54 > + Change methods to take a WirtingMode parameter instead of a RenderStyle pointer. Typo: WritingMode > Source/WebCore/rendering/style/RenderStyleConstants.h:-136 > -}; Nit: May be good to leave some comment about where to find WritingMode's definition, especially since we don't include it here.
Committed r126437: <http://trac.webkit.org/changeset/126437>