RESOLVED FIXED 94140
Remove StyleSheetContents::m_finalURL 
https://bugs.webkit.org/show_bug.cgi?id=94140
Summary Remove StyleSheetContents::m_finalURL
Antti Koivisto
Reported 2012-08-15 13:32:33 PDT
It is always the same as baseURL().
Attachments
patch (13.94 KB, patch)
2012-08-15 13:40 PDT, Antti Koivisto 		kling: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-04 (844.74 KB, application/zip)
2012-08-15 14:32 PDT, WebKit Review Bot 		no flags
Details
patch (16.74 KB, patch)
2012-08-16 05:36 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
another (17.09 KB, patch)
2012-08-16 06:46 PDT, Antti Koivisto 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-08 (548.50 KB, application/zip)
2012-08-16 07:41 PDT, WebKit Review Bot 		no flags
Details
try to fix chromium serializer test (16.91 KB, patch)
2012-08-16 11:36 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2012-08-15 13:40:11 PDT
Created attachment 158630 [details] patch
Andreas Kling
Comment 2 2012-08-15 13:43:24 PDT
Comment on attachment 158630 [details] patch r=me, though please consider removing the actual variable too.
Antti Koivisto
Comment 3 2012-08-15 14:03:44 PDT
(In reply to comment #2) > (From update of attachment 158630 [details]) > r=me, though please consider removing the actual variable too. An excellent idea!
WebKit Review Bot
Comment 4 2012-08-15 14:32:46 PDT
Comment on attachment 158630 [details] patch Attachment 158630 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13509333 New failing tests: WebPageNewSerializeTest.FAILS_TestMHTMLEncoding http/tests/security/data-url-inline.css.html WebPageNewSerializeTest.FAILS_CSSResources
WebKit Review Bot
Comment 5 2012-08-15 14:32:50 PDT
Created attachment 158637 [details] Archive of layout-test-results from gce-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Antti Koivisto
Comment 6 2012-08-16 05:36:37 PDT
Created attachment 158785 [details] patch
WebKit Review Bot
Comment 7 2012-08-16 05:48:51 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13513548
Peter Beverloo (cr-android ews)
Comment 8 2012-08-16 05:49:34 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13514359
Early Warning System Bot
Comment 9 2012-08-16 06:04:21 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13518147
Gyuyoung Kim
Comment 10 2012-08-16 06:09:38 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13506715
Early Warning System Bot
Comment 11 2012-08-16 06:11:25 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13506714
Build Bot
Comment 12 2012-08-16 06:28:46 PDT
Comment on attachment 158785 [details] patch Attachment 158785 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13517339
Antti Koivisto
Comment 13 2012-08-16 06:46:22 PDT
Created attachment 158801 [details] another
WebKit Review Bot
Comment 14 2012-08-16 07:41:31 PDT
Comment on attachment 158801 [details] another Attachment 158801 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13512486 New failing tests: WebPageNewSerializeTest.FAILS_TestMHTMLEncoding WebPageNewSerializeTest.FAILS_CSSResources
WebKit Review Bot
Comment 15 2012-08-16 07:41:35 PDT
Created attachment 158818 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Antti Koivisto
Comment 16 2012-08-16 11:36:05 PDT
Created attachment 158864 [details] try to fix chromium serializer test
Antti Koivisto
Comment 17 2012-08-16 13:30:45 PDT
http://trac.webkit.org/changeset/125805
Note You need to log in before you can comment on or make changes to this bug.