Bug 94129 – Mark Skia and Compositor Contexts

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Gregg Tavares]

Mark Skia and Compositor Contexts

[Gregg Tavares]

Created attachment 158602 [details]
Patch

[Gregg Tavares]

This CL just marks those contexts to aid in debugging.

[James Robinson]

Comment on attachment 158602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158602&action=review

Do you have to pop these markers ever?

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:694
> +    context3d->pushGroupMarkerEXT("CompositorContext");

This would be better in LayerRendererChromium::initialize() - all WGC3D stuff should be down there.

[Gregg Tavares]

Created attachment 158614 [details]
Patch

[Gregg Tavares]

moved marking the compositor context from CCLayerTreeHostImpl it to LayerRendererChromium

[Gregg Tavares]

(In reply to comment #3)
> (From update of attachment 158602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158602&action=review
> 
> Do you have to pop these markers ever?

No (or yes). They basically are just for debugging so when the gpu process prints a message it will print the marker. pushGroupMarker is like namespace. insertEventMarker sets the current "marker" for the current group. So

pushGroupMaker("foo");
enable(1234); // invalid enum
insertEventMarker("orange");
pushGroupMaker("bar");
enable(1234); // invalid enum
insertEventMarker("hello");
enable(1234); // invalid enum
insertEventMarker("world");
enable(1234); // invalid enum
popGroupMarker();
enable(1234); // invalid enum

should print something like

.foo: glEnable INVALID_ENUM
.foo.orange: glEnable INVALID_ENUM
.foo.bar: glEnable INVALID_ENUM
.foo.bar.hello: glEnable INVALID_ENUM
.foo.bar.word: glEnable INVALID_ENUM
.foo.orange: glEnable INVALID_ENUM

It's safe to pop too many times.

These values can get passed down to the driver and used in perf tools but I'm not currently passing them down to the driver

> 
> > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:694
> > +    context3d->pushGroupMarkerEXT("CompositorContext");
> 
> This would be better in LayerRendererChromium::initialize() - all WGC3D stuff should be down there.

[WebKit Review Bot]

Comment on attachment 158614 [details]
Patch

Clearing flags on attachment: 158614

Committed r125703: <http://trac.webkit.org/changeset/125703>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.