BinaryPropertyList.cpp has calls to appendByte which cause compile errors when compiling with MSVC for a 64-bit machine. Since all the overloads of appendByte do the same thing which casts to an unsigned char anyway (see lines 392-414 of the same file), casting them before the call should not change performance (especially since the functions are inline) but it will allow compiling for win64. https://github.com/achristensen07/webkit64prep patch coming soon
Created attachment 158589 [details] Patch
Comment on attachment 158589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158589&action=review I think the intent of this change is good, but please switch to the more explicit C++-style cast; I think this is just a static_cast<>. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:700 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); We use C++-style casts in the Coding Guideline: static_cast<unsigned char>(asciiStringMarkerByte | length) > Source/WebCore/platform/cf/BinaryPropertyList.cpp:709 > + appendByte((unsigned char)(unicodeStringMarkerByte | length)); Ditto. > Source/WebCore/platform/cf/BinaryPropertyList.cpp:726 > + appendByte((unsigned char)(asciiStringMarkerByte | length)); Ditto
Created attachment 158855 [details] patch
Comment on attachment 158855 [details] patch Clearing flags on attachment: 158855 Committed r126357: <http://trac.webkit.org/changeset/126357>
All reviewed patches have been landed. Closing bug.