WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94117
[BlackBerry] Use nested layout when rotating
https://bugs.webkit.org/show_bug.cgi?id=94117
Summary
[BlackBerry] Use nested layout when rotating
Leo Yang
Reported
2012-08-15 08:41:55 PDT
RIM PR #181548 When rotating the content with used for layout is not correct. We need to use nested layout to re-determine the final layout.
Attachments
Patch
(3.91 KB, patch)
2012-08-15 08:47 PDT
,
Leo Yang
no flags
Details
Formatted Diff
Diff
Patch v2
(3.90 KB, patch)
2012-08-15 08:51 PDT
,
Leo Yang
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Leo Yang
Comment 1
2012-08-15 08:47:22 PDT
Created
attachment 158574
[details]
Patch
WebKit Review Bot
Comment 2
2012-08-15 08:49:48 PDT
Attachment 158574
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/Api/WebPage.cpp:2524: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Leo Yang
Comment 3
2012-08-15 08:51:41 PDT
Created
attachment 158575
[details]
Patch v2
WebKit Review Bot
Comment 4
2012-08-15 09:20:55 PDT
Comment on
attachment 158575
[details]
Patch v2 Clearing flags on attachment: 158575 Committed
r125680
: <
http://trac.webkit.org/changeset/125680
>
WebKit Review Bot
Comment 5
2012-08-15 09:20:58 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug