Bug 94117 - [BlackBerry] Use nested layout when rotating
Summary: [BlackBerry] Use nested layout when rotating
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-08-15 08:41 PDT by Leo Yang
Modified: 2012-08-15 09:20 PDT (History)
3 users (show)

See Also:

Patch (3.91 KB, patch)
2012-08-15 08:47 PDT, Leo Yang
no flags Details | Formatted Diff | Diff
Patch v2 (3.90 KB, patch)
2012-08-15 08:51 PDT, Leo Yang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Yang 2012-08-15 08:41:55 PDT
RIM PR #181548
When rotating the content with used for layout is not correct. We need to use nested layout to re-determine the final layout.
Comment 1 Leo Yang 2012-08-15 08:47:22 PDT
Created attachment 158574 [details]
Comment 2 WebKit Review Bot 2012-08-15 08:49:48 PDT
Attachment 158574 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/Api/WebPage.cpp:2524:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Leo Yang 2012-08-15 08:51:41 PDT
Created attachment 158575 [details]
Patch v2
Comment 4 WebKit Review Bot 2012-08-15 09:20:55 PDT
Comment on attachment 158575 [details]
Patch v2

Clearing flags on attachment: 158575

Committed r125680: <http://trac.webkit.org/changeset/125680>
Comment 5 WebKit Review Bot 2012-08-15 09:20:58 PDT
All reviewed patches have been landed.  Closing bug.