Bug 94116 – Web Inspector: CodeMirror breakpoints and gutter look different than the default ones

• Status: RESOLVED
• Resolution: INVALID
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

See screenshot attached.

[Pavel Feldman]

Created attachment 158573 [details]
[IMAGE] Editor breakpoint rendering diff

[Jan Keromnes]

I think they look better. Is the goal really to copy DefaultTextEditor pixel by pixel?

[Pavel Feldman]

(In reply to comment #2)
> I think they look better. Is the goal really to copy DefaultTextEditor pixel by pixel?

I think new looks renders line number better, I also like the new gutter border color for being not that intense. But I also find new breakpoints looking heavy. Adding Patrick to give an advice on the better looks.

It is not that we are targeting pixel-by-pixel similarity, but we should try hard in making the editors look alike. If that is not feasible due to the codemirror limitations (like with messages) - that is fine - we will look for workarounds. But by default, we should copy the looks.

[Jan Keromnes]

I also find the new breakpoints look a little heavy. This is due to the 1px border image width on top and bottom of the breakpoints. But changing it back to 0px makes the border intersect with the line numbers, making them less readable. Maybe there's a compromise we can reach.

Also worth noting, Thaddee Tyl brought to my attention that my breakpoints look a bit like the new Safari Devtools breakpoints: https://devimages.apple.com.edgekey.net/technologies/safari/images/tools_gallery/tools-breakpoints.jpg