Bug 94115 - [BlackBerry] Check for valid field focus before processing a spellcheck request
Summary: [BlackBerry] Check for valid field focus before processing a spellcheck request
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nima Ghanavatian
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 08:21 PDT by Nima Ghanavatian
Modified: 2012-08-15 08:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2012-08-15 08:29 PDT, Nima Ghanavatian 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nima Ghanavatian 2012-08-15 08:21:50 PDT 
SSIA
Comment 1 Nima Ghanavatian 2012-08-15 08:29:58 PDT 
Created attachment 158572 [details]
Patch
Comment 2 Rob Buis 2012-08-15 08:34:51 PDT 
Comment on attachment 158572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158572&action=review

LGTM.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:540
> +        return;

Could be made into a macro since we do this block a lot.
Comment 3 WebKit Review Bot 2012-08-15 08:50:20 PDT 
Comment on attachment 158572 [details]
Patch

Clearing flags on attachment: 158572

Committed r125676: <http://trac.webkit.org/changeset/125676>
Comment 4 WebKit Review Bot 2012-08-15 08:50:23 PDT 
All reviewed patches have been landed.  Closing bug.