Bug 94113 - VCSUtils.pm: git log --grep='git-svn-id: ' fails on Windows
Summary: VCSUtils.pm: git log --grep='git-svn-id: ' fails on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 07:51 PDT by Kevin Funk
Modified: 2012-08-15 08:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (965 bytes, patch)
2012-08-15 07:52 PDT, Kevin Funk
no flags Details | Formatted Diff | Diff
Patch v2 (1.58 KB, patch)
2012-08-15 08:05 PDT, Kevin Funk
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Funk 2012-08-15 07:51:50 PDT
Title says it all. Need to enquote the string with "" instead.

Patch attached.
Comment 1 Kevin Funk 2012-08-15 07:52:23 PDT
Created attachment 158569 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-15 07:55:04 PDT
Could you create a "proper" patch, ie. follow the project guidelines, and include a changelog entry. Use the script Tools/Scripts/prepare-ChangeLog to get started :-)
Comment 3 Kevin Funk 2012-08-15 08:05:15 PDT
Created attachment 158570 [details]
Patch v2
Comment 4 WebKit Review Bot 2012-08-15 08:47:02 PDT
Comment on attachment 158570 [details]
Patch v2

Clearing flags on attachment: 158570

Committed r125675: <http://trac.webkit.org/changeset/125675>
Comment 5 WebKit Review Bot 2012-08-15 08:47:06 PDT
All reviewed patches have been landed.  Closing bug.