Bug 94104 - [EFL][WK2] Add unit tests for WKEinaSharedString
Summary: [EFL][WK2] Add unit tests for WKEinaSharedString
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 90451
  Show dependency tree / graph
 
Reported: 2012-08-15 06:51 PDT by Mikhail Pozdnyakov
Modified: 2012-08-20 04:52 PDT (History)
6 users (show)

See Also:

Attachments
patch (5.97 KB, patch)
2012-08-20 01:52 PDT, Mikhail Pozdnyakov 		kenneth: review+
Details | Formatted Diff | Diff
patch v2 (6.01 KB, patch)
2012-08-20 03:38 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-08-15 06:51:15 PDT 
Unit tests for WKEinaSharedString are to be added.
Comment 1 Mikhail Pozdnyakov 2012-08-20 01:52:16 PDT 
Created attachment 159369 [details]
patch
Comment 2 Kenneth Rohde Christiansen 2012-08-20 01:57:55 PDT 
Comment on attachment 159369 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159369&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_eina_shared_string.cpp:42
> +static const char testString[] = "I'm test string!";
> +static const char anotherTestString[] = "I'm another test string!";

Why not make two alike here?
Comment 3 Mikhail Pozdnyakov 2012-08-20 03:38:24 PDT 
Created attachment 159388 [details]
patch v2

Use always different string objects.
Comment 4 WebKit Review Bot 2012-08-20 04:52:42 PDT 
Comment on attachment 159388 [details]
patch v2

Clearing flags on attachment: 159388

Committed r126019: <http://trac.webkit.org/changeset/126019>
Comment 5 WebKit Review Bot 2012-08-20 04:52:47 PDT 
All reviewed patches have been landed.  Closing bug.