Bug 94099 – Parser stage for CSS Hierarchies

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Shane Stephens]

Parser stage for CSS Hierarchies

[Shane Stephens]

Created attachment 158556 [details]
Patch

[WebKit Review Bot]

Comment on attachment 158556 [details]
Patch

Attachment 158556 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13501656

New failing tests:
fast/dom/shadow/content-selector-query.html
printing/pseudo-class-outside-page.html
jquery/traversing.html
jquery/attributes.html
fast/css/css3-nth-tokens-script.html
fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml
jquery/css.html
jquery/event.html

[WebKit Review Bot]

Created attachment 158563 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Antti Koivisto]

Please surround all code related to this experimental feature with  #if !ENABLE(CSS_HIERARCHIES) .

[Antti Koivisto]

-!

[Tony Chang]

Comment on attachment 158556 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158556&action=review

> LayoutTests/css3/hierarchies-parsing.html:9
> +    & .inner {
> +        background-color: red;

There should be a lot more tests, including tests that are expected to fail.
- multiple levels of &
- & at the top level
- & without a space after it
- & with a newline after it
- & {
- &{
- & &
- &&
- & .inner #foo
- & #foo
- & div
- & :active
etc.

> LayoutTests/platform/chromium/TestExpectations:166
> +// CSS Hierarchies are not yet enabled.
> +BUGWK79939 SKIP : css3/hierarchies-parsing.html = PASS

Please put all the hierarchies tests in a subdirectory, e.g., css3/hierarchies/parsing.html.  That will make it easier to skip the whole directory and easier for you to run the tests.

> LayoutTests/platform/mac/TestExpectations:26
> +// CSS Hierarchies are not yet enabled.
> +BUGWK79939 SKIP : css3/hierarchies-parsing.html = PASS

I would consider running this test on mac with the failing expectation checked in.  That way we can be sure that height is not set for .outer if hierarchies is not compiled in.

[Anders Carlsson]

CSS Hierarchies has been removed, see 

https://bugs.webkit.org/show_bug.cgi?id=102554