Bug 94098 - Web Inspector: Scroll/selection are not saved in sources panel editors sometimes.
Summary: Web Inspector: Scroll/selection are not saved in sources panel editors someti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 05:57 PDT by Vsevolod Vlasov
Modified: 2012-08-15 06:54 PDT (History)
12 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2012-08-15 06:03 PDT, Vsevolod Vlasov 		pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (430.88 KB, application/zip)
2012-08-15 06:39 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-08-15 05:57:10 PDT 
The reason is that we unconditionally clear TabbedEditorContainer's _currentFile field when tab is closed.

Patch to follow.
Comment 1 Vsevolod Vlasov 2012-08-15 06:03:38 PDT 
Created attachment 158554 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-15 06:39:47 PDT 
Comment on attachment 158554 [details]
Patch

Attachment 158554 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13501647

New failing tests:
inspector/debugger/scripts-panel.html
Comment 3 WebKit Review Bot 2012-08-15 06:39:51 PDT 
Created attachment 158560 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Vsevolod Vlasov 2012-08-15 06:54:13 PDT 
Committed r125672: <http://trac.webkit.org/changeset/125672>