Bug 94070 - [CSS Regions] broken feature detection: syntax parsing succeeds when ENABLE_CSS_REGIONS is false
Summary: [CSS Regions] broken feature detection: syntax parsing succeeds when ENABLE_C...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mihai Maerean
URL:
Keywords:
: 98884 (view as bug list)
Depends on: 101192
Blocks: 57312
  Show dependency tree / graph
 
Reported: 2012-08-14 22:27 PDT by Paul Irish
Modified: 2014-02-03 07:30 PST (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Irish 2012-08-14 22:27:12 PDT 
1. If CSS Regions is not enabled (it's turned off in about:flags in Chrome) then the following should be true

    document.body.style.webkitRegionOverflow == undefined

Currently it'll return an empty string.

2. Additionally, in http://adobe.github.com/web-platform/utilities/css-regions-support-matrix/
One of the assertions ('Initial default value for region-overflow') will pass in Chrome Canary with the flag turned off.  Chrome should score a 0 with the feature turned off.

3. With this fixed, feature detects would fail fast:
https://github.com/Modernizr/Modernizr/blob/b18048b4b4245326d7f6f5a998df58050acf51a9/feature-detects/css-regions.js#L12-17

4. More importantly, this may end up being a false positive in the upcoming @supports functionality (bug 86146)

Thanks!

(Feel free to rename ticket if I've gotten the details wrong)
Comment 1 Hajime Morrita 2012-10-14 05:42:47 PDT 
*** Bug 98884 has been marked as a duplicate of this bug. ***
Comment 2 Michelangelo De Simone 2013-06-13 20:26:58 PDT 
This seems to be a Chromium bug, closing.
Comment 3 Mihai Balan 2013-06-14 02:13:38 PDT 
The bug actually has some WebKit ramifications, too.
Keeping it open.
Comment 4 Mihai Balan 2014-02-03 07:30:37 PST 
Since Regions are enabled by default in Safari, will close as RESOLVED/INVALID