Bug 94067 - Update test expectations for css3/filters/custom/invalid-custom-filter-shader.html failing on Apple Lion Debug WK1 (Tests)
Summary: Update test expectations for css3/filters/custom/invalid-custom-filter-shader...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kiran Muppala
Keywords: LayoutTestFailure
Depends on:
Reported: 2012-08-14 21:23 PDT by Kiran Muppala
Modified: 2012-08-15 19:44 PDT (History)
4 users (show)

See Also:

Patch (1.49 KB, patch)
2012-08-14 21:37 PDT, Kiran Muppala
no flags Details | Formatted Diff | Diff
Patch (1.67 KB, patch)
2012-08-15 16:18 PDT, Kiran Muppala
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kiran Muppala 2012-08-14 21:23:24 PDT
The test css3/filters/custom/invalid-custom-filter-shader.html started failing on Apple Lion Debug WK1 (Tests) between 125459 and 125464.


This is most likely caused by http://trac.webkit.org/changeset/125462:
WebKit+SVG does not support color-interpolation-filters or draw filters in correct colorspace
Comment 1 Kiran Muppala 2012-08-14 21:37:24 PDT
Created attachment 158498 [details]
Comment 2 Florin Malita 2012-08-15 00:54:27 PDT
The image diff is expected as filters are now applied in a different color space by default, so it should be fine to mark it for rebaseline instead of regression.

Quite a few tests need rebaselining (see the BUGWK6033 lines in TestExpectations), but the original patch missed this particular one. Thanks for catching it.
Comment 3 Kiran Muppala 2012-08-15 16:18:10 PDT
Created attachment 158655 [details]
Comment 4 Kiran Muppala 2012-08-15 16:20:29 PDT
Attached patch to add css3/filters/custom/invalid-custom-filter-shader.html to the list of test needing re-baselining after https://bugs.webkit.org/show_bug.cgi?id=6033
Comment 5 WebKit Review Bot 2012-08-15 16:27:09 PDT
Comment on attachment 158655 [details]

Rejecting attachment 158655 [details] from commit-queue.

cmuppala@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 6 WebKit Review Bot 2012-08-15 18:04:10 PDT
Comment on attachment 158655 [details]

Clearing flags on attachment: 158655

Committed r125731: <http://trac.webkit.org/changeset/125731>
Comment 7 WebKit Review Bot 2012-08-15 18:04:13 PDT
All reviewed patches have been landed.  Closing bug.