Bug 94066 - Use literal initialization for CSS's pseudo types
Summary: Use literal initialization for CSS's pseudo types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 20:53 PDT by Benjamin Poulain
Modified: 2012-08-15 12:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.50 KB, patch)
2012-08-14 20:59 PDT, Benjamin Poulain 		kenneth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-04 (567.92 KB, application/zip)
2012-08-14 22:36 PDT, WebKit Review Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-14 20:53:35 PDT 
Literal initialization is gooood, let's spread it :)
Comment 1 Benjamin Poulain 2012-08-14 20:59:17 PDT 
Created attachment 158493 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-14 22:36:38 PDT 
Comment on attachment 158493 [details]
Patch

Attachment 158493 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13510062

New failing tests:
http/tests/security/mixedContent/filesystem-url-in-iframe.html
Comment 3 WebKit Review Bot 2012-08-14 22:36:42 PDT 
Created attachment 158504 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Benjamin Poulain 2012-08-14 22:52:00 PDT 
> New failing tests:
> http/tests/security/mixedContent/filesystem-url-in-iframe.html

I have serious doubts CSS pseudo elements caused the failure :)
Comment 5 Benjamin Poulain 2012-08-15 12:38:47 PDT 
Committed r125697: <http://trac.webkit.org/changeset/125697>