Bug 94060 - [Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux
Summary: [Chromium] fast/dom/Window/dom-access-from-closure-window.html is flaky on Linux
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2012-08-14 19:29 PDT by Yuta Kitamura
Modified: 2012-08-15 01:26 PDT (History)
5 users (show)

See Also:

Need to check JSC (3.59 KB, patch)
2012-08-14 23:45 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (5.88 KB, patch)
2012-08-15 00:17 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2012-08-14 19:29:57 PDT
The following test is flaky on Chromium-Linux bots:


Looks like http://trac.webkit.org/changeset/125592 fixed the issue which caused this test to fail consistently, but it introduced a new flakiness (or revealed the hidden flakiness).

It seems Mac and Windows are okay at this moment.

Diffs look like the following:

--- /b/build/slave/Webkit_Linux__dbg_/build/layout-test-results/fast/dom/Window/dom-access-from-closure-window-expected.txt 
+++ /b/build/slave/Webkit_Linux__dbg_/build/layout-test-results/fast/dom/Window/dom-access-from-closure-window-actual.txt 
@@ -1,5 +1,4 @@
-document.URL: LayoutTests/fast/dom/Window/resources/dom-access-from-closure-window-child.html
-window.document.URL: LayoutTests/fast/dom/Window/resources/notify-opener-done.html
-name: child
-window.name: child
+CONSOLE MESSAGE: Unsafe JavaScript attempt to access frame with URL notify-opener-done.html. Domains, protocols and ports must match.
+An exception was thrown: Cannot read property 'URL' of undefined
Comment 1 Adam Barth 2012-08-14 20:22:57 PDT
Thanks.  This does sound related to my patch.
Comment 2 Adam Barth 2012-08-14 22:11:24 PDT
The flakiness seems to be gc-dependent.  If you call gc() as the first statement in done(), you can repro 100% of the time.
Comment 3 Adam Barth 2012-08-14 23:45:26 PDT
Created attachment 158509 [details]
Need to check JSC
Comment 4 Adam Barth 2012-08-15 00:17:40 PDT
Created attachment 158515 [details]
Comment 5 Kentaro Hara 2012-08-15 00:24:53 PDT
Comment on attachment 158515 [details]

Looks reasonable.
Comment 6 WebKit Review Bot 2012-08-15 01:26:22 PDT
Comment on attachment 158515 [details]

Clearing flags on attachment: 158515

Committed r125656: <http://trac.webkit.org/changeset/125656>
Comment 7 WebKit Review Bot 2012-08-15 01:26:26 PDT
All reviewed patches have been landed.  Closing bug.