Bug 94030 – [WebGL] Mac/ATI/AMD systems need to translate built-in GLSL functions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Dean Jackson]

WebGL conformance test suite build: 5a7a067ead6 Tue Aug 7 14:34:42 2012 -0700
WebKit: r125123 on Mountain Lion 12A269
GPU: AMD Radeon HD 6750M 1024 MB (yes, fairly old)

[Radar WebKit Bug Importer]

<rdar://problem/12099678>

[Dean Jackson]

It seems like Apple ports, unlike Chrome, are not picking up ANGLE's function emulation. In particular: TFunctionDistance1_1 which is marked as problematic on ATI and NVidia cards.

[Dean Jackson]

Here is ANGLE adding a distance emulation: 
http://code.google.com/p/angleproject/source/detail?spec=svn1255&r=754

[Dean Jackson]

Original title was [WebGL] conformance/glsl/functions/glsl-function-distance.html failing on Apple Mountain Lion

[Dean Jackson]

Created attachment 159835 [details]
Patch

[WebKit Review Bot]

Attachment 159835 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/graphics/ANGLEWebKitBridge.h:56:  The parameter name "shaderType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dean Jackson]

I deliberately ignored the style warning: didn't want to change an existing parameter def in this patch.

[Dean Jackson]

*** Bug 94032 has been marked as a duplicate of this bug. ***

[Dean Jackson]

*** Bug 94031 has been marked as a duplicate of this bug. ***

[Tim Horton]

Comment on attachment 159835 [details]
Patch

Should probably use a typedef for the flags.

[Dean Jackson]

(In reply to comment #10)
> (From update of attachment 159835 [details])
> Should probably use a typedef for the flags.

ShCompileOptions is the enum of the various options. Not sure what we could call the typedef - maybe ANGLECompileOptions? Anyway, this code will be updated very soon and I'll address it then.

[Dean Jackson]

Committed r126342: <http://trac.webkit.org/changeset/126342>