94024 – Add parsing of CSS compositing's blend-mode

Bug 94024 - Add parsing of CSS compositing's blend-mode

Summary: Add parsing of CSS compositing's blend-mode

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	528+ (Nightly build)
Hardware:	All All

Importance:	P2 Normal
Assignee:	Rik Cabanier

URL:
Keywords:

Depends on:	94485
Blocks:	91908
	Show dependency tree / graph

Reported:	2012-08-14 15:35 PDT by Rik Cabanier
Modified:	2012-08-20 17:35 PDT (History)
CC List:	9 users (show)

See Also:

Attachments
first patch to see if everything still builds (22.26 KB, patch) 2012-08-16 11:25 PDT, Rik Cabanier	webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from gce-cr-linux-06 (308.92 KB, application/zip) 2012-08-16 13:34 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from gce-cr-linux-02 (325.06 KB, application/zip) 2012-08-16 14:34 PDT, WebKit Review Bot	no flags	Details
second patch with test results (25.26 KB, patch) 2012-08-16 15:18 PDT, Rik Cabanier	krit: review-	Details \| Formatted Diff \| Diff
patch that tests all blendmodes (30.05 KB, patch) 2012-08-18 13:34 PDT, Rik Cabanier	webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from gce-cr-linux-07 (322.77 KB, application/zip) 2012-08-18 14:43 PDT, WebKit Review Bot	no flags	Details
Archive of layout-test-results from gce-cr-linux-04 (378.38 KB, application/zip) 2012-08-18 15:42 PDT, WebKit Review Bot	no flags	Details
updated result file (34.86 KB, patch) 2012-08-18 15:50 PDT, Rik Cabanier	no flags	Details \| Formatted Diff \| Diff
updated result file (30.40 KB, patch) 2012-08-18 15:52 PDT, Rik Cabanier	krit: review- krit: commit-queue-	Details \| Formatted Diff \| Diff
expanded second test (39.55 KB, patch) 2012-08-19 14:09 PDT, Rik Cabanier	webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from gce-cr-linux-03 (378.63 KB, application/zip) 2012-08-19 15:20 PDT, WebKit Review Bot	no flags	Details
fixed changelog + patched expected text for test (39.44 KB, patch) 2012-08-19 15:41 PDT, Rik Cabanier	no flags	Details \| Formatted Diff \| Diff
added platform specific test files (39.59 KB, patch) 2012-08-20 09:43 PDT, Rik Cabanier	no flags	Details \| Formatted Diff \| Diff
added missing result file (61.05 KB, patch) 2012-08-20 09:49 PDT, Rik Cabanier	no flags	Details \| Formatted Diff \| Diff
moved files around (56.20 KB, patch) 2012-08-20 12:38 PDT, Rik Cabanier	krit: review+	Details \| Formatted Diff \| Diff
did a sync to resolve conflict (56.12 KB, patch) 2012-08-20 17:20 PDT, Rik Cabanier	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (15) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Rik Cabanier 2012-08-14 15:35:51 PDT

This is part of the process of adding compositing/blending support to webkit.
This patch will add support for the parsing of the first keyword -webkit-blend-mode. Rendering will be done in subsequent patches.

Comment 1 Rik Cabanier 2012-08-16 11:25:14 PDT

Created attachment 158859 [details]
first patch to see if everything still builds

Comment 2 WebKit Review Bot 2012-08-16 13:34:14 PDT

Comment on attachment 158859 [details]
first patch to see if everything still builds

Attachment 158859 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13510733

New failing tests:
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
css3/compositing/blend-mode-property-parsing-invalid.html

Comment 3 WebKit Review Bot 2012-08-16 13:34:17 PDT

Created attachment 158889 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 4 WebKit Review Bot 2012-08-16 14:34:39 PDT

Comment on attachment 158859 [details]
first patch to see if everything still builds

Attachment 158859 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13521106

New failing tests:
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html
css3/compositing/blend-mode-property-parsing-invalid.html

Comment 5 WebKit Review Bot 2012-08-16 14:34:43 PDT

Created attachment 158905 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 6 Rik Cabanier 2012-08-16 15:18:10 PDT

Created attachment 158921 [details]
second patch with test results

Comment 7 Dirk Schulze 2012-08-16 17:06:33 PDT

Comment on attachment 158921 [details]
second patch with test results

View in context: https://bugs.webkit.org/attachment.cgi?id=158921&action=review

The patch LGTM. Just the tests need more tweaks.

> Source/WebCore/ChangeLog:8
> +        Added parsing and general CSS handling of -webkit-blend-mode per http://www.w3.org/TR/2012/WD-compositing-20120816/

Link to WD, wow! :D

> LayoutTests/css3/compositing/script-tests/blend-mode-property-parsing.js:47
> +testFilterRule("Basic reference",
> +               "multiply", 1, "multiply");

I would like to see a test for all keywords, not just 'multiply' so that we can make sure that we support all and not accidentally remove support of one. This can be done with a simple for-loop on an array ["multiply", '"normal", ....].

> LayoutTests/css3/compositing/script-tests/blend-mode-property.js:16
> +var declaration = cssRule.style;
> +shouldBe("declaration.length", "1");
> +shouldBe("declaration.getPropertyValue('-webkit-blend-mode')", "\'multiply\'");

Same comment as above.

Comment 8 Rik Cabanier 2012-08-18 13:34:19 PDT

Created attachment 159268 [details]
patch that tests all blendmodes

Comment 9 WebKit Review Bot 2012-08-18 14:43:14 PDT

Comment on attachment 159268 [details]
patch that tests all blendmodes

Attachment 159268 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13530402

New failing tests:
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html

Comment 10 WebKit Review Bot 2012-08-18 14:43:18 PDT

Created attachment 159269 [details]
Archive of layout-test-results from gce-cr-linux-07

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-07  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 11 WebKit Review Bot 2012-08-18 15:42:39 PDT

Comment on attachment 159268 [details]
patch that tests all blendmodes

Attachment 159268 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13521793

New failing tests:
css3/compositing/blend-mode-property-parsing.html
css3/compositing/blend-mode-property.html

Comment 12 WebKit Review Bot 2012-08-18 15:42:43 PDT

Created attachment 159273 [details]
Archive of layout-test-results from gce-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 13 Rik Cabanier 2012-08-18 15:50:12 PDT

Created attachment 159274 [details]
updated result file

Comment 14 Rik Cabanier 2012-08-18 15:52:18 PDT

Created attachment 159275 [details]
updated result file

Comment 15 Dirk Schulze 2012-08-19 13:37:58 PDT

Comment on attachment 159275 [details]
updated result file

View in context: https://bugs.webkit.org/attachment.cgi?id=159275&action=review

just some snippets left.

> LayoutTests/css3/compositing/script-tests/blend-mode-property-parsing.js:46
> +testFilterRule("Basic reference",

use the same array like for blend-mode-propery.js. Rename testFilterRule to testBlendModeRule.

Comment 16 Rik Cabanier 2012-08-19 14:09:32 PDT

Created attachment 159303 [details]
expanded second test

Comment 17 WebKit Review Bot 2012-08-19 15:20:11 PDT

Comment on attachment 159303 [details]
expanded second test

Attachment 159303 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13537513

New failing tests:
css3/compositing/blend-mode-property-parsing.html

Comment 18 WebKit Review Bot 2012-08-19 15:20:16 PDT

Created attachment 159305 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

Comment 19 Rik Cabanier 2012-08-19 15:41:49 PDT

Created attachment 159310 [details]
fixed changelog + patched expected text for test

Comment 20 Dirk Schulze 2012-08-19 19:51:44 PDT

Comment on attachment 159310 [details]
fixed changelog + patched expected text for test

LGTM. r=me.

Comment 21 WebKit Review Bot 2012-08-19 20:33:57 PDT

Comment on attachment 159310 [details]
fixed changelog + patched expected text for test

Clearing flags on attachment: 159310

Committed r125989: <http://trac.webkit.org/changeset/125989>

Comment 22 WebKit Review Bot 2012-08-19 20:34:03 PDT

All reviewed patches have been landed.  Closing bug.

Comment 23 Brady Eidson 2012-08-20 09:06:08 PDT

css3/compositing/blend-mode-property-parsing.html
and
css3/compositing/blend-mode-property.html

Have been failing on the Mac bots since check-in.

Comment 24 Brady Eidson 2012-08-20 09:07:09 PDT

(In reply to comment #23)
> css3/compositing/blend-mode-property-parsing.html
> and
> css3/compositing/blend-mode-property.html
> 
> Have been failing on the Mac bots since check-in.

Example failures:
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r126026%20(2039)/results.html

Comment 25 WebKit Review Bot 2012-08-20 09:08:02 PDT

Re-opened since this is blocked by 94485

Comment 26 Rik Cabanier 2012-08-20 09:43:24 PDT

Created attachment 159454 [details]
added platform specific test files

Comment 27 Rik Cabanier 2012-08-20 09:49:30 PDT

Created attachment 159455 [details]
added missing result file

Comment 28 Rik Cabanier 2012-08-20 12:38:46 PDT

Created attachment 159490 [details]
moved files around

Comment 29 Dirk Schulze 2012-08-20 13:57:44 PDT

Comment on attachment 159490 [details]
moved files around

second try. r=me.

Comment 30 Brady Eidson 2012-08-20 14:21:57 PDT

Sorry about the rollout this morning guys.  Thanks for following up with green tests!

Comment 31 WebKit Review Bot 2012-08-20 14:58:01 PDT

Comment on attachment 159490 [details]
moved files around

Rejecting attachment 159490 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13545224

Comment 32 Rik Cabanier 2012-08-20 17:20:55 PDT

Created attachment 159570 [details]
did a sync to resolve conflict

Comment 33 Dirk Schulze 2012-08-20 17:35:47 PDT

Comment on attachment 159570 [details]
did a sync to resolve conflict

Clearing flags on attachment: 159570

Committed r126105: <http://trac.webkit.org/changeset/126105>

Comment 34 Dirk Schulze 2012-08-20 17:35:53 PDT

All reviewed patches have been landed.  Closing bug.