Bug 93999 - [BlackBerry] Don't crash on OOM in AC
Summary: [BlackBerry] Don't crash on OOM in AC
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 10:41 PDT by Filip Spacek
Modified: 2012-08-14 14:20 PDT (History)
3 users (show)

See Also:

Attachments
Fail gracefully in case of OOM (2.89 KB, patch)
2012-08-14 10:43 PDT, Filip Spacek 		staikos: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Fail gracefully in case of OOM (2.89 KB, patch)
2012-08-14 13:16 PDT, Filip Spacek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Spacek 2012-08-14 10:41:44 PDT 
When we fail to allocate the bitmap surface for the contents of the AC layer, we should bail and not attempt any rendering.
Comment 1 Filip Spacek 2012-08-14 10:43:22 PDT 
Created attachment 158367 [details]
Fail gracefully in case of OOM
Comment 2 WebKit Review Bot 2012-08-14 12:50:14 PDT 
Comment on attachment 158367 [details]
Fail gracefully in case of OOM

Rejecting attachment 158367 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13500381
Comment 3 Filip Spacek 2012-08-14 13:16:00 PDT 
Created attachment 158402 [details]
Fail gracefully in case of OOM

Now with OOPS!
Comment 4 WebKit Review Bot 2012-08-14 14:20:17 PDT 
Comment on attachment 158402 [details]
Fail gracefully in case of OOM

Clearing flags on attachment: 158402

Committed r125605: <http://trac.webkit.org/changeset/125605>
Comment 5 WebKit Review Bot 2012-08-14 14:20:20 PDT 
All reviewed patches have been landed.  Closing bug.