Bug 93997 - [Chromium] Fix warnings on Windows build
Summary: [Chromium] Fix warnings on Windows build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Scott Graham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 10:31 PDT by Scott Graham
Modified: 2012-08-14 17:33 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.57 KB, patch)
2012-08-14 10:34 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
Patch (5.88 KB, patch)
2012-08-14 16:48 PDT, Scott Graham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Graham 2012-08-14 10:31:22 PDT 
[Chromium] Fix warnings on Windows build
Comment 1 Scott Graham 2012-08-14 10:34:58 PDT 
Created attachment 158365 [details]
Patch
Comment 2 Kentaro Hara 2012-08-14 16:30:11 PDT 
Comment on attachment 158365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review

> Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
>      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));

Don't you also need to change 0.5 to 0.5f?
Comment 3 Scott Graham 2012-08-14 16:35:27 PDT 
(In reply to comment #2)
> (From update of attachment 158365 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review
> 
> > Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
> >      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));
> 
> Don't you also need to change 0.5 to 0.5f?

No, 0.5 is exactly representable as a float, so there's no truncation.
Comment 4 Kentaro Hara 2012-08-14 16:43:14 PDT 
Comment on attachment 158365 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review

>>> Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
>>>      EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));
>> 
>> Don't you also need to change 0.5 to 0.5f?
> 
> No, 0.5 is exactly representable as a float, so there's no truncation.

Makes sense. Then let's add the comment. People will wonder why this test uses 0.3f and 0.5.
Comment 5 Scott Graham 2012-08-14 16:48:32 PDT 
Created attachment 158445 [details]
Patch
Comment 6 Kentaro Hara 2012-08-14 16:52:35 PDT 
Comment on attachment 158445 [details]
Patch

Looks OK
Comment 7 WebKit Review Bot 2012-08-14 17:33:36 PDT 
Comment on attachment 158445 [details]
Patch

Clearing flags on attachment: 158445

Committed r125625: <http://trac.webkit.org/changeset/125625>
Comment 8 WebKit Review Bot 2012-08-14 17:33:40 PDT 
All reviewed patches have been landed.  Closing bug.