Bug 93977 – Implement testRunner.numberOfPendingGeolocationPermissionRequests()

• Status: NEW
• Component: Tools / Tests

[Sergio Villar Senin]

At least required by fast/dom/Geolocation/page-reload-cancel-permission-requests.html

[Javier Fernandez]

Created attachment 203964 [details]
Patch

[Darin Adler]

Comment on attachment 203964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203964&action=review

> Tools/WebKitTestRunner/TestInvocation.cpp:679
> +        int number = TestController::shared().numberOfPendingGeolocationPermissionRequests();
> +        WKRetainPtr<WKTypeRef> result(AdoptWK, WKUInt64Create(number));
> +        return result;

The right way to write this is:

    return adoptWK(WKUInt64Create(TestController::shared().numberOfPendingGeolocationPermissionRequests()));

No need for the local variables.

[Benjamin Poulain]

Comment on attachment 203964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203964&action=review

This is wrong.

I think you missed what this test does.

On reload, WebKit should call GeolocationClient::cancelPermissionRequest() which should in turn cancel the permissionRequest on the UIProcess side. This part is not wired to anything which is why that does not work.
You are just breaking the test to make it pass.

> LayoutTests/ChangeLog:4
> +
> +        The testsRunner should request for Geolocation Permissions.
> +        Unskip test.

The description goes under the title. See the other changelogs.

> LayoutTests/fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js:15
> +    if (!isReload) {
> +      testRunner.setGeolocationPermission(true);
> +    }

Wrong indent.

You are breaking the test by doing this. Why do you do that?

[Benjamin Poulain]

Please CC/Ping me for Geolocation patches.