Bug 93970 - REGRESSION r125500: 7 tests crashing on Mac bots
Summary: REGRESSION r125500: 7 tests crashing on Mac bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thomas Sepez
URL: http://build-safari.apple.com/results...
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-14 08:26 PDT by Eric Carlson
Modified: 2012-08-14 14:02 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2012-08-14 11:50 PDT, Thomas Sepez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2012-08-14 08:26:59 PDT
The following tests started crashing on the Mac bots between r125497 and r125500 (inclusive):

    http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
    userscripts/user-script-top-frame-only.html
    fast/loader/reload-zero-byte-plugin.html
    fast/frames/iframe-plugin-load-remove-document-crash.html
    plugins/plugin-document-back-forward.html
    plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
    plugins/inner-html-display-none.html

http://trac.webkit.org/log/trunk?rev=125500&stop_rev=125497&limit=5

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125495%20%282315%29/results.html succeeded
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125500%20%282316%29/results.html failed
Comment 1 Thomas Sepez 2012-08-14 09:44:14 PDT
Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283.  Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch.
Comment 2 Eric Carlson 2012-08-14 09:52:39 PDT
(In reply to comment #1)
> Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283.  Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch.

I don't have access to the bug. Can you fix it?
Comment 3 Thomas Sepez 2012-08-14 11:50:10 PDT
Created attachment 158387 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-08-14 12:16:49 PDT
Comment on attachment 158387 [details]
Patch

OK.
Comment 5 WebKit Review Bot 2012-08-14 14:02:39 PDT
Comment on attachment 158387 [details]
Patch

Clearing flags on attachment: 158387

Committed r125601: <http://trac.webkit.org/changeset/125601>
Comment 6 WebKit Review Bot 2012-08-14 14:02:43 PDT
All reviewed patches have been landed.  Closing bug.