Bug 93970 – REGRESSION r125500: 7 tests crashing on Mac bots

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Carlson]

The following tests started crashing on the Mac bots between r125497 and r125500 (inclusive):

    http/tests/security/contentSecurityPolicy/object-src-url-blocked.html
    userscripts/user-script-top-frame-only.html
    fast/loader/reload-zero-byte-plugin.html
    fast/frames/iframe-plugin-load-remove-document-crash.html
    plugins/plugin-document-back-forward.html
    plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html
    plugins/inner-html-display-none.html

http://trac.webkit.org/log/trunk?rev=125500&stop_rev=125497&limit=5

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125495%20%282315%29/results.html succeeded
http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125500%20%282316%29/results.html failed

[Thomas Sepez]

Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283.  Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch.

[Eric Carlson]

(In reply to comment #1)
> Undoubtedly fallout from https://bugs.webkit.org/show_bug.cgi?id=93283.  Eric, I'd suggest putting the NULL checks back in for the other ports that we'd agreed to remove from the original patch.

I don't have access to the bug. Can you fix it?

[Thomas Sepez]

Created attachment 158387 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 158387 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 158387 [details]
Patch

Clearing flags on attachment: 158387

Committed r125601: <http://trac.webkit.org/changeset/125601>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.