Bug 93961 – Automatic features should work in sandboxed iframes if "allow-scripts" flag is set

• Status: RESOLVED
• Resolution: FIXED
• Component: Frames

[Jussi Kukkonen (jku)]

Looks like media/no-auto-play-in-sandbox.html test (and the functionality it tests) is wrong.

It expects the media to _not_ autoplay in an iframe with sandbox="allow-scripts allow-same-origin". This seems incorrect as according to spec (both whatwg and w3c working draft) autoplay is restricted by "automatic features browsing context flag" which should not be set if allow-scripts is set.

[Chris Dumez]

A manual test is available at:
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-block-autoplay-video.htm

[Chris Dumez]

It also impacts:
fast/forms/no-autofocus-in-sandbox.html

Autofocus should work in a sandboxed iframe that has allow-scripts flag set (according to latest spec).

Manual test:
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-block-autofocus-form-control.htm

[Chris Dumez]

Created attachment 161974 [details]
Patch

Unfortunately, the present patch removes the test cases that check that autoplay / autofocus are blocked in sandboxed iframes. Those tests are no longer working since they rely on the "allow-scripts" flag to be set in order to work.
It is not easy to automatically test this but I'm open to suggestions on how to better handle this.

I have validated the patch using the LayoutTests added in the patch and the following manual tests:
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-block-autoplay-video.htm
http://samples.msdn.microsoft.com/ietestcenter/html5/sandbox/automatic-feature-block-autofocus-form-control.htm

[Eric Seidel (no email)]

This is for you Adam. :)

[Adam Barth]

Comment on attachment 161974 [details]
Patch

Thanks for fixing this.  Yeah, I'm not sure how to test these features anymore...

[WebKit Review Bot]

Comment on attachment 161974 [details]
Patch

Clearing flags on attachment: 161974

Committed r127481: <http://trac.webkit.org/changeset/127481>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.