Bug 93943 - [Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to SpinButtonElement.{cpp,h}
Summary: [Forms] Copy Source/WebCore/html/shadow/TextControlInnerElements.{cpp,h} to S...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 94289
  Show dependency tree / graph
 
Reported: 2012-08-14 01:23 PDT by yosin
Modified: 2012-08-17 01:18 PDT (History)
2 users (show)

See Also:

Attachments
Patch 1 (30.93 KB, patch)
2012-08-14 02:22 PDT, yosin 		tkent: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-14 01:23:49 PDT 
This is part of setting SpinButtonElement free from HTMLInputElement.
Comment 1 yosin 2012-08-14 02:22:55 PDT 
Created attachment 158266 [details]
Patch 1
Comment 2 yosin 2012-08-14 02:23:51 PDT 
Comment on attachment 158266 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Note: The diff is result of "svn copy".
Comment 3 WebKit Review Bot 2012-08-14 02:26:54 PDT 
Attachment 158266 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/html/shadow/SpinButtonElement.h:27:  #ifndef header guard has wrong style, please use: SpinButtonElement_h  [build/header_guard] [5]
Source/WebCore/html/shadow/SpinButtonElement.h:178:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/html/shadow/SpinButtonElement.cpp:28:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/html/shadow/SpinButtonElement.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 4 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Kent Tamura 2012-08-14 02:54:53 PDT 
Comment on attachment 158266 [details]
Patch 1

ok
Comment 5 yosin 2012-08-16 23:37:07 PDT 
Landed: http://trac.webkit.org/changeset/125862