Bug 93915 - [WK2] Track multiple Web Processes per context
Summary: [WK2] Track multiple Web Processes per context
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 17:33 PDT by Alexey Proskuryakov
Modified: 2012-08-14 15:58 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (16.24 KB, patch)
2012-08-13 17:43 PDT, Alexey Proskuryakov 		sam: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
For EWS (18.18 KB, patch)
2012-08-14 13:31 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-08-13 17:33:59 PDT 
Patch forthcoming.
Comment 1 Alexey Proskuryakov 2012-08-13 17:43:33 PDT 
Created attachment 158166 [details]
proposed patch
Comment 2 WebKit Review Bot 2012-08-13 17:45:24 PDT 
Attachment 158166 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebContext.cpp:479:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit2/UIProcess/WebContext.cpp:490:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit2/UIProcess/WebContext.cpp:523:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2012-08-13 18:14:51 PDT 
Comment on attachment 158166 [details]
proposed patch

Beautiful. r=me.
Comment 4 Sam Weinig 2012-08-13 18:15:08 PDT 
Oh, but please fix the builds first.
Comment 5 Gyuyoung Kim 2012-08-13 18:18:26 PDT 
Comment on attachment 158166 [details]
proposed patch

Attachment 158166 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13489431
Comment 6 Build Bot 2012-08-13 20:34:07 PDT 
Comment on attachment 158166 [details]
proposed patch

Attachment 158166 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13490375
Comment 7 Alexey Proskuryakov 2012-08-14 13:31:07 PDT 
Created attachment 158405 [details]
For EWS

Checking build fixes.
Comment 8 WebKit Review Bot 2012-08-14 13:33:12 PDT 
Attachment 158405 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/WebContext.cpp:484:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit2/UIProcess/WebContext.cpp:495:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Source/WebKit2/UIProcess/WebContext.cpp:528:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Alexey Proskuryakov 2012-08-14 14:07:01 PDT 
Committed <http://trac.webkit.org/changeset/125602>.