Bug 93914 - IndexedDB: add tracing to IDBLevelDBBackingStore
Summary: IndexedDB: add tracing to IDBLevelDBBackingStore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alec Flett
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 17:30 PDT by Alec Flett
Modified: 2012-08-14 18:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (16.63 KB, patch)
2012-08-13 17:31 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch (16.71 KB, patch)
2012-08-14 13:14 PDT, Alec Flett
no flags Details | Formatted Diff | Diff
Patch for landing (16.73 KB, patch)
2012-08-14 17:33 PDT, Alec Flett
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-08-13 17:30:29 PDT
IndexedDB: add tracing to IDBLevelDBBackingStore
Comment 1 Alec Flett 2012-08-13 17:31:43 PDT
Created attachment 158158 [details]
Patch
Comment 2 Alec Flett 2012-08-14 11:40:22 PDT
pretty straight forward - also I moved the static findKeyInIndex into IDBLevelDBBackingStore because I want to mess with its const-ness for bug 91127, and since I was adding a IDB_TRACE...

jsbell@ / dgrogan@ - any objections?
Comment 3 Joshua Bell 2012-08-14 11:54:04 PDT
Comment on attachment 158158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review

LGTM (Could quibble about including the refactoring here vs. in 91127, but it's harmless.)

> Source/WebCore/ChangeLog:10
> +        from core IDB slowness.

Add note about moving findKeyInIndex

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:88
> +

Nit: Remove this blank line.

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89
> +    bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey);

Need to expose this in IDBBackingStore too?
Comment 4 Alec Flett 2012-08-14 13:14:32 PDT
Comment on attachment 158158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review

>> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89
>> +    bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey);
> 
> Need to expose this in IDBBackingStore too?

Nope, only used by members of this class.
Comment 5 Alec Flett 2012-08-14 13:14:43 PDT
Created attachment 158401 [details]
Patch
Comment 6 Alec Flett 2012-08-14 13:15:19 PDT
tony@ - r?
Comment 7 Tony Chang 2012-08-14 17:26:24 PDT
Comment on attachment 158401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158401&action=review

> Source/WebCore/ChangeLog:15
> +        No new tests (OOPS!).

You need to update this line for why there are no tests.
Comment 8 Alec Flett 2012-08-14 17:33:14 PDT
Created attachment 158455 [details]
Patch for landing
Comment 9 WebKit Review Bot 2012-08-14 18:18:40 PDT
Comment on attachment 158455 [details]
Patch for landing

Clearing flags on attachment: 158455

Committed r125627: <http://trac.webkit.org/changeset/125627>
Comment 10 WebKit Review Bot 2012-08-14 18:18:44 PDT
All reviewed patches have been landed.  Closing bug.