Bug 93914 – IndexedDB: add tracing to IDBLevelDBBackingStore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alec Flett]

IndexedDB: add tracing to IDBLevelDBBackingStore

[Alec Flett]

Created attachment 158158 [details]
Patch

[Alec Flett]

pretty straight forward - also I moved the static findKeyInIndex into IDBLevelDBBackingStore because I want to mess with its const-ness for bug 91127, and since I was adding a IDB_TRACE...

jsbell@ / dgrogan@ - any objections?

[Joshua Bell]

Comment on attachment 158158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review

LGTM (Could quibble about including the refactoring here vs. in 91127, but it's harmless.)

> Source/WebCore/ChangeLog:10
> +        from core IDB slowness.

Add note about moving findKeyInIndex

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:88
> +

Nit: Remove this blank line.

> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89
> +    bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey);

Need to expose this in IDBBackingStore too?

[Alec Flett]

Comment on attachment 158158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158158&action=review

>> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.h:89
>> +    bool findKeyInIndex(int64_t databaseId, int64_t objectStoreId, int64_t indexId, const IDBKey&, Vector<char>& foundEncodedPrimaryKey);
> 
> Need to expose this in IDBBackingStore too?

Nope, only used by members of this class.

[Alec Flett]

Created attachment 158401 [details]
Patch

[Alec Flett]

tony@ - r?

[Tony Chang]

Comment on attachment 158401 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158401&action=review

> Source/WebCore/ChangeLog:15
> +        No new tests (OOPS!).

You need to update this line for why there are no tests.

[Alec Flett]

Created attachment 158455 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 158455 [details]
Patch for landing

Clearing flags on attachment: 158455

Committed r125627: <http://trac.webkit.org/changeset/125627>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.