RESOLVED FIXED 93907
[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols 
https://bugs.webkit.org/show_bug.cgi?id=93907
Summary [chromium] Make WebAnimation a pure virtual interface to hide implementation ...
James Robinson
Reported 2012-08-13 15:32:53 PDT
[chromium] Make WebAnimation a pure virtual interface to hide implementation and avoid unresolved symbols
Attachments
Patch (23.61 KB, patch)
2012-08-13 15:40 PDT, James Robinson 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-13 15:40:37 PDT
Created attachment 158134 [details] Patch
James Robinson
Comment 2 2012-08-13 15:41:35 PDT
Darin - is this what you had in mind? If so I'll go ahead and convert the rest of the WebPrivateOwnPtr<> types in the compositor interface family over and introduce a tearoff factory section to Platform.h's exported thingies.
WebKit Review Bot
Comment 3 2012-08-13 15:42:49 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
James Robinson
Comment 4 2012-08-13 16:45:45 PDT
Committed r125469: <http://trac.webkit.org/changeset/125469>
Darin Fisher (:fishd, Google)
Comment 5 2012-08-13 22:33:08 PDT
Comment on attachment 158134 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158134&action=review > Source/Platform/chromium/public/WebAnimation.h:53 > + WEBKIT_EXPORT static WebAnimation* create(const WebAnimationCurve&, TargetProperty); Just to be clear about what we discussed, a future step would be to turn these static functions into virtual functions of some factory interface (i.e., CompositorSupport::createAnimation).
Note You need to log in before you can comment on or make changes to this bug.