WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 93905
Enable CSS Sticky Position on Windows.
https://bugs.webkit.org/show_bug.cgi?id=93905
Summary
Enable CSS Sticky Position on Windows.
Roger Fong
Reported
2012-08-13 15:19:51 PDT
As per
https://bugs.webkit.org/show_bug.cgi?id=90046
, the ENABLE_CSS_STICKY_POSITION needs to be turned on for Windows as well.
Attachments
patch
(5.19 KB, patch)
2012-08-13 15:39 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
re-patch
(5.19 KB, patch)
2012-08-13 15:47 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
re-re-patch
(5.15 KB, patch)
2012-08-13 15:56 PDT
,
Roger Fong
thorton
: review+
webkit.review.bot
: commit-queue-
Details
Formatted Diff
Diff
updated to lastest revision...although it shouldn't have mattered
(5.15 KB, patch)
2012-08-13 17:29 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
forgot the url
(5.17 KB, patch)
2012-08-13 17:31 PDT
,
Roger Fong
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Roger Fong
Comment 1
2012-08-13 15:39:05 PDT
Created
attachment 158133
[details]
patch There may have been a define that was not in it's proper alphabetized location (also the indentation was completely off) and it happened to be right where I was going to put the new define... I may have fixed it here as well...
Roger Fong
Comment 2
2012-08-13 15:47:19 PDT
Created
attachment 158137
[details]
re-patch I'm a hypocrite and screwed the style up myself
Roger Fong
Comment 3
2012-08-13 15:56:06 PDT
Created
attachment 158138
[details]
re-re-patch
WebKit Review Bot
Comment 4
2012-08-13 17:10:26 PDT
Comment on
attachment 158138
[details]
re-re-patch Rejecting
attachment 158138
[details]
from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ommit-queue/Source/WebKit/chromium/third_party/snappy/src --revision 63 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 47>At revision 63. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output:
http://queues.webkit.org/results/13500004
Roger Fong
Comment 5
2012-08-13 17:29:57 PDT
Created
attachment 158155
[details]
updated to lastest revision...although it shouldn't have mattered
Tim Horton
Comment 6
2012-08-13 17:31:06 PDT
Comment on
attachment 158155
[details]
updated to lastest revision...although it shouldn't have mattered View in context:
https://bugs.webkit.org/attachment.cgi?id=158155&action=review
> WebKitLibraries/ChangeLog:4 > + Need the bug URL (OOPS!).
Oops. Bad reviewer.
Roger Fong
Comment 7
2012-08-13 17:31:54 PDT
Created
attachment 158159
[details]
forgot the url
WebKit Review Bot
Comment 8
2012-08-13 17:57:42 PDT
Comment on
attachment 158159
[details]
forgot the url Clearing flags on attachment: 158159 Committed
r125485
: <
http://trac.webkit.org/changeset/125485
>
WebKit Review Bot
Comment 9
2012-08-13 17:57:46 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug