Bug 93885 - [GTK] String returned by g_path_get_dirname() must be freed
Summary: [GTK] String returned by g_path_get_dirname() must be freed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sudarsana Nagineni (babu)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 13:06 PDT by Sudarsana Nagineni (babu)
Modified: 2012-08-14 00:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2012-08-13 13:18 PDT, Sudarsana Nagineni (babu) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sudarsana Nagineni (babu) 2012-08-13 13:06:29 PDT 
Memory leak in GTK's DRT code. To fix the leak, string retuned by g_path_get_dirname() must be freed.

==13984== 102 bytes in 2 blocks are definitely lost in loss record 9,327 of 10,890
==13984==    at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==13984==    by 0xCB3AA38: g_malloc (gmem.c:159)
==13984==    by 0xCB23A35: g_path_get_dirname (gfileutils.c:2454)
==13984==    by 0x474F61: pathFromSoupURI(_SoupURI*) (DumpRenderTree.cpp:1130)
==13984==    by 0x47507B: convertSoupMessageToURLPath(_SoupMessage*) (DumpRenderTree.cpp:1141)
==13984==    by 0x4750BD: convertNetworkRequestToURLPath(_WebKitNetworkRequest*) (DumpRenderTree.cpp:1147)
==13984==    by 0x47582C: willSendRequestCallback(_WebKitWebView*, _WebKitWebFrame*, _WebKitWebResource*, _WebKitNetworkRequest*, _WebKitNetworkResponse*) (DumpRenderTree.cpp:1263)
==13984==    by 0x6F0681E: webkit_marshal_VOID__OBJECT_OBJECT_OBJECT_OBJECT (webkitmarshal.cpp:1124)
==13984==    by 0xC8ADCA1: g_closure_invoke (gclosure.c:777)
==13984==    by 0xC8BED70: signal_emit_unlocked_R (gsignal.c:3547)
==13984==    by 0xC8C7098: g_signal_emit_valist (gsignal.c:3296)
==13984==    by 0xC8C7753: g_signal_emit_by_name (gsignal.c:3389)
Comment 1 Sudarsana Nagineni (babu) 2012-08-13 13:18:59 PDT 
Created attachment 158086 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-14 00:31:49 PDT 
Comment on attachment 158086 [details]
Patch

Clearing flags on attachment: 158086

Committed r125515: <http://trac.webkit.org/changeset/125515>
Comment 3 WebKit Review Bot 2012-08-14 00:31:53 PDT 
All reviewed patches have been landed.  Closing bug.