Bug 93864 - Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condition as well
Summary: Media(Stream|Element)AudioSourceNode should be guarded by the WEB_AUDIO condi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 10:38 PDT by Zan Dobersek
Modified: 2012-08-13 13:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2012-08-13 10:49 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2012-08-13 11:03 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2012-08-13 10:38:11 PDT 
Currently the MediaStreamAudioSourceNode lists only the MEDIA_SOURCE feature under the Conditional attribute. The compilation then fails when the MEDIA_STREAM feature is enabled but the WEB_AUDIO feature is not.

Both guards are used in MediaStreamAudioSourceNode.cpp but only MEDIA_STREAM in MediaStreamAudioSourceNode.h.
Comment 1 Zan Dobersek 2012-08-13 10:49:54 PDT 
Created attachment 158041 [details]
Patch
Comment 2 Zan Dobersek 2012-08-13 10:54:50 PDT 
MediaElementAudioSourceNode suffers the same issue, meaning there would be compilation errors when enabling WEB_AUDIO and disabling the VIDEO feature.

Just to make it clear, the GTK port intends to include all the files into the build, regardless of any feature being enabled or not. The GTK port currently enables the MEDIA_STREAM feature and disables WEB_AUDIO, and that's where the errors were first noticed.
Comment 3 Zan Dobersek 2012-08-13 10:55:32 PDT 
Changing the title accordingly, uploading a new patch soon.
Comment 4 Zan Dobersek 2012-08-13 11:03:32 PDT 
Created attachment 158046 [details]
Patch
Comment 5 WebKit Review Bot 2012-08-13 13:18:13 PDT 
Comment on attachment 158046 [details]
Patch

Clearing flags on attachment: 158046

Committed r125440: <http://trac.webkit.org/changeset/125440>
Comment 6 WebKit Review Bot 2012-08-13 13:18:17 PDT 
All reviewed patches have been landed.  Closing bug.