RESOLVED FIXED93861
[BlackBerry] Pass String's 8-bit buffer directly to platform layer when possible 
https://bugs.webkit.org/show_bug.cgi?id=93861
Summary [BlackBerry] Pass String's 8-bit buffer directly to platform layer when possible
Yong Li
Reported 2012-08-13 10:10:14 PDT
to avoid extra copy
Attachments
the patch (7.09 KB, patch)
2012-08-13 13:06 PDT, Yong Li 		rwlbuis: review+
yong.li.webkit: commit-queue-
DetailsFormatted DiffDiff
to commit (7.08 KB, patch)
2012-08-14 08:40 PDT, Yong Li 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yong Li
Comment 1 2012-08-13 13:06:02 PDT
Created attachment 158083 [details] the patch
WebKit Review Bot
Comment 2 2012-08-13 13:10:36 PDT
Attachment 158083 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/blackberry/ReadOnlyLatin1String.h:19: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 3 2012-08-13 13:35:13 PDT
Comment on attachment 158083 [details] the patch LGTM.
Yong Li
Comment 4 2012-08-14 08:40:35 PDT
Created attachment 158341 [details] to commit
WebKit Review Bot
Comment 5 2012-08-14 10:19:52 PDT
Comment on attachment 158341 [details] to commit Clearing flags on attachment: 158341 Committed r125576: <http://trac.webkit.org/changeset/125576>
WebKit Review Bot
Comment 6 2012-08-14 10:19:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.