Bug 93861 - [BlackBerry] Pass String's 8-bit buffer directly to platform layer when possible
Summary: [BlackBerry] Pass String's 8-bit buffer directly to platform layer when possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 10:10 PDT by Yong Li
Modified: 2012-08-14 10:19 PDT (History)
3 users (show)

See Also:

Attachments
the patch (7.09 KB, patch)
2012-08-13 13:06 PDT, Yong Li 		rwlbuis: review+
yong.li.webkit: commit-queue-
Details | Formatted Diff | Diff
to commit (7.08 KB, patch)
2012-08-14 08:40 PDT, Yong Li 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yong Li 2012-08-13 10:10:14 PDT 
to avoid extra copy
Comment 1 Yong Li 2012-08-13 13:06:02 PDT 
Created attachment 158083 [details]
the patch
Comment 2 WebKit Review Bot 2012-08-13 13:10:36 PDT 
Attachment 158083 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/platform/blackberry/ReadOnlyLatin1String.h:19:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Rob Buis 2012-08-13 13:35:13 PDT 
Comment on attachment 158083 [details]
the patch

LGTM.
Comment 4 Yong Li 2012-08-14 08:40:35 PDT 
Created attachment 158341 [details]
to commit
Comment 5 WebKit Review Bot 2012-08-14 10:19:52 PDT 
Comment on attachment 158341 [details]
to commit

Clearing flags on attachment: 158341

Committed r125576: <http://trac.webkit.org/changeset/125576>
Comment 6 WebKit Review Bot 2012-08-14 10:19:55 PDT 
All reviewed patches have been landed.  Closing bug.