Bug 93860 - Plumb through EXT_debug_marker entry points
Summary: Plumb through EXT_debug_marker entry points
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Gregg Tavares
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 09:37 PDT by Gregg Tavares
Modified: 2012-08-14 10:52 PDT (History)
10 users (show)

See Also:

Attachments
Patch (11.38 KB, patch)
2012-08-13 09:44 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (11.73 KB, patch)
2012-08-13 10:19 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Patch (11.91 KB, patch)
2012-08-13 18:16 PDT, Gregg Tavares 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregg Tavares 2012-08-13 09:37:17 PDT 
Plumb through EXT_debug_marker entry points
Comment 1 Gregg Tavares 2012-08-13 09:44:53 PDT 
Created attachment 158024 [details]
Patch
Comment 2 Gregg Tavares 2012-08-13 10:19:42 PDT 
Created attachment 158033 [details]
Patch
Comment 3 WebKit Review Bot 2012-08-13 10:23:16 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Kenneth Russell 2012-08-13 11:16:43 PDT 
Comment on attachment 158033 [details]
Patch

Looks fine; r=me. Let's wait for it to clear the EWS before setting cq+.
Comment 5 WebKit Review Bot 2012-08-13 11:26:33 PDT 
Comment on attachment 158033 [details]
Patch

Attachment 158033 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13480835
Comment 6 Gregg Tavares 2012-08-13 18:16:33 PDT 
Created attachment 158176 [details]
Patch
Comment 7 Kenneth Russell 2012-08-13 18:26:43 PDT 
Comment on attachment 158176 [details]
Patch

r=me again
Comment 8 WebKit Review Bot 2012-08-13 23:51:13 PDT 
Comment on attachment 158176 [details]
Patch

Rejecting attachment 158176 [details] from commit-queue.

gman@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 9 WebKit Review Bot 2012-08-14 10:52:04 PDT 
Comment on attachment 158176 [details]
Patch

Clearing flags on attachment: 158176

Committed r125580: <http://trac.webkit.org/changeset/125580>
Comment 10 WebKit Review Bot 2012-08-14 10:52:09 PDT 
All reviewed patches have been landed.  Closing bug.