Bug 93857 - HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack
Summary: HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLEleme...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kwang Yul Seo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 09:26 PDT by Kwang Yul Seo
Modified: 2012-08-22 14:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (20.06 KB, patch)
2012-08-13 09:32 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2012-08-13 09:26:09 PDT
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack because it traverses the element stack and finds the furthest formatting element. 

Currently, it belongs to HTMLTreeBuilder just because isSpecialNode(const HTMLStackItem*) function used by furthestBlockForFormattingElement is internal to HTMLTreeBuilder. By moving isSpecialNode to HTMLStackItem, we can move furthestBlockForFormattingElement to HTMLElementStack.
Comment 1 Kwang Yul Seo 2012-08-13 09:32:13 PDT
Created attachment 158016 [details]
Patch
Comment 2 Kwang Yul Seo 2012-08-13 09:33:01 PDT
This patch is just a refactoring, not relevant to speculative parsing.
Comment 3 WebKit Review Bot 2012-08-22 14:54:48 PDT
Comment on attachment 158016 [details]
Patch

Clearing flags on attachment: 158016

Committed r126355: <http://trac.webkit.org/changeset/126355>
Comment 4 WebKit Review Bot 2012-08-22 14:54:51 PDT
All reviewed patches have been landed.  Closing bug.