WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
93857
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack
https://bugs.webkit.org/show_bug.cgi?id=93857
Summary
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLEleme...
Kwang Yul Seo
Reported
2012-08-13 09:26:09 PDT
HTMLTreeBuilder::furthestBlockForFormattingElement should belong to HTMLElementStack because it traverses the element stack and finds the furthest formatting element. Currently, it belongs to HTMLTreeBuilder just because isSpecialNode(const HTMLStackItem*) function used by furthestBlockForFormattingElement is internal to HTMLTreeBuilder. By moving isSpecialNode to HTMLStackItem, we can move furthestBlockForFormattingElement to HTMLElementStack.
Attachments
Patch
(20.06 KB, patch)
2012-08-13 09:32 PDT
,
Kwang Yul Seo
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1
2012-08-13 09:32:13 PDT
Created
attachment 158016
[details]
Patch
Kwang Yul Seo
Comment 2
2012-08-13 09:33:01 PDT
This patch is just a refactoring, not relevant to speculative parsing.
WebKit Review Bot
Comment 3
2012-08-22 14:54:48 PDT
Comment on
attachment 158016
[details]
Patch Clearing flags on attachment: 158016 Committed
r126355
: <
http://trac.webkit.org/changeset/126355
>
WebKit Review Bot
Comment 4
2012-08-22 14:54:51 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug