RESOLVED FIXED93851
Web Inspector: get rid of beforeTextChanged 
https://bugs.webkit.org/show_bug.cgi?id=93851
Summary Web Inspector: get rid of beforeTextChanged
Pavel Feldman
Reported 2012-08-13 08:17:52 PDT
We should only work with onTextChanged (event, telling something has changed).
Attachments
Patch (13.05 KB, patch)
2012-08-13 08:41 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (12.17 KB, patch)
2012-08-13 08:48 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-13 08:41:23 PDT
Created attachment 158008 [details] Patch
Pavel Feldman
Comment 2 2012-08-13 08:48:42 PDT
Created attachment 158009 [details] Patch
Vsevolod Vlasov
Comment 3 2012-08-13 09:24:27 PDT
Comment on attachment 158009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158009&action=review > Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:184 > + for (var lineNumber = 0; lineNumber < this._textEditor.linesCount; ++lineNumber) { Maybe if (!supportsBreakpointsOnEdit) { for (var lineNumber = 0; lineNumber < this._textEditor.linesCount; ++lineNumber) { var breakpointDecoration = this._textEditor.getAttribute(lineNumber, "breakpoint"); if (breakpointDecoration) this._addBreakpointDecoration(lineNumber, breakpointDecoration.condition, breakpointDecoration.enabled, true); } }
WebKit Review Bot
Comment 4 2012-08-13 09:50:05 PDT
Comment on attachment 158009 [details] Patch Clearing flags on attachment: 158009 Committed r125426: <http://trac.webkit.org/changeset/125426>
WebKit Review Bot
Comment 5 2012-08-13 09:50:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.