Bug 93851 - Web Inspector: get rid of beforeTextChanged
Summary: Web Inspector: get rid of beforeTextChanged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 08:17 PDT by Pavel Feldman
Modified: 2012-08-13 09:50 PDT (History)
11 users (show)

See Also:

Attachments
Patch (13.05 KB, patch)
2012-08-13 08:41 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Patch (12.17 KB, patch)
2012-08-13 08:48 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-13 08:17:52 PDT 
We should only work with onTextChanged (event, telling something has changed).
Comment 1 Pavel Feldman 2012-08-13 08:41:23 PDT 
Created attachment 158008 [details]
Patch
Comment 2 Pavel Feldman 2012-08-13 08:48:42 PDT 
Created attachment 158009 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-08-13 09:24:27 PDT 
Comment on attachment 158009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158009&action=review

> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:184
> +            for (var lineNumber = 0; lineNumber < this._textEditor.linesCount; ++lineNumber) {

Maybe

if (!supportsBreakpointsOnEdit) {
    for (var lineNumber = 0; lineNumber < this._textEditor.linesCount; ++lineNumber) {
        var breakpointDecoration = this._textEditor.getAttribute(lineNumber, "breakpoint");
        if (breakpointDecoration)
            this._addBreakpointDecoration(lineNumber, breakpointDecoration.condition, breakpointDecoration.enabled, true);
    }
}
Comment 4 WebKit Review Bot 2012-08-13 09:50:05 PDT 
Comment on attachment 158009 [details]
Patch

Clearing flags on attachment: 158009

Committed r125426: <http://trac.webkit.org/changeset/125426>
Comment 5 WebKit Review Bot 2012-08-13 09:50:09 PDT 
All reviewed patches have been landed.  Closing bug.