Bug 93848 - [BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling
Summary: [BlackBerry] Rounding error somewhere when translating CompositingLayer 's fo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antonio Gomes
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 08:03 PDT by Antonio Gomes
Modified: 2012-08-13 12:26 PDT (History)
3 users (show)

See Also:


Attachments
patch (11.49 KB, patch)
2012-08-13 09:00 PDT, Antonio Gomes
no flags Details | Formatted Diff | Diff
patch v2 (13.06 KB, patch)
2012-08-13 11:42 PDT, Antonio Gomes
yong.li.webkit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antonio Gomes 2012-08-13 08:03:35 PDT
I can notice specially when zooming to the maximum and slowing pan the
in-region scrollable block.
Comment 1 Antonio Gomes 2012-08-13 09:00:34 PDT
Created attachment 158012 [details]
patch
Comment 2 WebKit Review Bot 2012-08-13 09:03:31 PDT
Attachment 158012 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/InRegionScrol..." exit_code: 1
Source/WebKit/blackberry/Api/InRegionScroller.cpp:222:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yong Li 2012-08-13 09:22:44 PDT
Comment on attachment 158012 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158012&action=review

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:65
> +    // FIXME: Negative values won't work with map{To,From}Transform methods.

map{To,From}Transform. a space?

> Source/WebKit/blackberry/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +

missing description here?
Comment 4 Antonio Gomes 2012-08-13 09:40:57 PDT
Comment on attachment 158012 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158012&action=review

>> Source/WebKit/blackberry/ChangeLog:8
>> +
> 
> missing description here?

I added description per-method below. Is that enough?
Comment 5 Antonio Gomes 2012-08-13 11:10:41 PDT
Comment on attachment 158012 [details]
patch

modified version coming,..
Comment 6 Antonio Gomes 2012-08-13 11:42:37 PDT
Created attachment 158061 [details]
patch v2

Patch caches a LayerWebKitThread as the camouflaged object, intead of a RenderLayer.

In a follow up patch that will get RefPtr'ed but can not happen quite yet 'cause that needs some refactoring first. On it next
Comment 7 Antonio Gomes 2012-08-13 12:26:29 PDT
Committed http://trac.webkit.org/changeset/125434