Bug 93848 – [BlackBerry] Rounding error somewhere when translating CompositingLayer 's for in-region scrolling

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Antonio Gomes]

I can notice specially when zooming to the maximum and slowing pan the
in-region scrollable block.

[Antonio Gomes]

Created attachment 158012 [details]
patch

[WebKit Review Bot]

Attachment 158012 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/InRegionScrol..." exit_code: 1
Source/WebKit/blackberry/Api/InRegionScroller.cpp:222:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yong Li]

Comment on attachment 158012 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158012&action=review

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:65
> +    // FIXME: Negative values won't work with map{To,From}Transform methods.

map{To,From}Transform. a space?

> Source/WebKit/blackberry/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +

missing description here?

[Antonio Gomes]

Comment on attachment 158012 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158012&action=review

>> Source/WebKit/blackberry/ChangeLog:8
>> +
> 
> missing description here?

I added description per-method below. Is that enough?

[Antonio Gomes]

Comment on attachment 158012 [details]
patch

modified version coming,..

[Antonio Gomes]

Created attachment 158061 [details]
patch v2

Patch caches a LayerWebKitThread as the camouflaged object, intead of a RenderLayer.

In a follow up patch that will get RefPtr'ed but can not happen quite yet 'cause that needs some refactoring first. On it next

[Antonio Gomes]

Committed http://trac.webkit.org/changeset/125434