RESOLVED FIXED93841
[Chromium] Fix apk generation for the Android platform 
https://bugs.webkit.org/show_bug.cgi?id=93841
Summary [Chromium] Fix apk generation for the Android platform
Peter Beverloo
Reported 2012-08-13 06:40:28 PDT
[Chromium] Fix apk generation for the Android platform
Attachments
Patch (3.91 KB, patch)
2012-08-13 06:42 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch (6.15 KB, patch)
2012-08-14 03:56 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Patch for landing (6.14 KB, patch)
2012-08-14 04:01 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2012-08-13 06:42:21 PDT
Created attachment 157987 [details] Patch
Peter Beverloo
Comment 2 2012-08-13 07:01:31 PDT
Comment on attachment 157987 [details] Patch The Chromium-side commit is in: https://src.chromium.org/viewvc/chrome?view=rev&revision=151257 This is safe to land even without a WebKit Chromium roll. Regardless, we're really close to ToT, so when the Chromium Waterfall rolls green on that patch, we can roll it to WebKit and the Android builders should become green again.
WebKit Review Bot
Comment 3 2012-08-13 09:41:00 PDT
Comment on attachment 157987 [details] Patch Clearing flags on attachment: 157987 Committed r125422: <http://trac.webkit.org/changeset/125422>
WebKit Review Bot
Comment 4 2012-08-13 09:41:04 PDT
All reviewed patches have been landed. Closing bug.
Florin Malita
Comment 5 2012-08-13 13:59:56 PDT
There's still a path problem: WK builds are still broken, as are the CR builds now - http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder?numbuilds=50 Error on WK builders: /mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/webkit_unit_tests_apk/native_test_apk.xml:21: Cannot find /mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/WebKit/chromium/build/android/ant/common.xml imported from /mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/webkit_unit_tests_apk/native_test_apk.xml Error on CR builders: /mnt/data/b/build/slave/Android_Builder/build/src/out/Release/TestWebKitAPI_apk/native_test_apk.xml:21: Cannot find /mnt/data/b/build/slave/Android_Builder/build/android/ant/common.xml imported from /mnt/data/b/build/slave/Android_Builder/build/src/out/Release/TestWebKitAPI_apk/native_test_apk.xml
WebKit Review Bot
Comment 6 2012-08-13 14:44:59 PDT
Re-opened since this is blocked by 93902
Florin Malita
Comment 7 2012-08-13 14:46:03 PDT
I'm reverting this for now, to hopefully get the canary bot green again and be able to roll WK.
Florin Malita
Comment 8 2012-08-13 14:55:50 PDT
http://trac.webkit.org/changeset/125454
Peter Beverloo
Comment 9 2012-08-14 03:56:20 PDT
Created attachment 158288 [details] Patch
Peter Beverloo
Comment 10 2012-08-14 03:57:54 PDT
Sorry about that, Florin! The updated patch also takes the different paths Chromium uses into account. To emphasize, the made modifications are to Android-specific sections of the gyp files. The larger problem causing all of this will be addressed on the Chromium side, eventually getting rid of this condition block as a whole.
Peter Beverloo
Comment 11 2012-08-14 04:01:21 PDT
Created attachment 158289 [details] Patch for landing Since Dimitri rubberstamped a version similar to this, and it is, after all, an Android-specific build fix, I'm going to go ahead and land this unreviewed.
Peter Beverloo
Comment 12 2012-08-14 04:02:46 PDT
Committed r125538: <http://trac.webkit.org/changeset/125538>
Peter Beverloo
Comment 13 2012-08-14 04:33:10 PDT
Committed r125542: <http://trac.webkit.org/changeset/125542>
Note You need to log in before you can comment on or make changes to this bug.