RESOLVED FIXED 93834
[V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h 
https://bugs.webkit.org/show_bug.cgi?id=93834
Summary [V8] Move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h
Kentaro Hara
Reported 2012-08-13 05:56:29 PDT
We can move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.
Attachments
Patch (3.92 KB, patch)
2012-08-13 05:57 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-13 05:57:46 PDT
Created attachment 157975 [details] Patch
Adam Barth
Comment 2 2012-08-13 10:39:15 PDT
Comment on attachment 157975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157975&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:525 > + if (data->shouldCollectGarbageSoon()) { Prefer early return. > Source/WebCore/bindings/v8/V8GCController.cpp:526 > + const int longIdlePauseInMs = 1000; longIdlePauseInMs -> longIdlePauseInMS > Source/WebCore/bindings/v8/V8GCController.h:79 > + static void hintForGCIfNecessary(); Can we think of a better name for this function? Perhaps collectGarbageIfNecessary?
Kentaro Hara
Comment 3 2012-08-13 18:32:20 PDT
(In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:525 > > + if (data->shouldCollectGarbageSoon()) { > > Prefer early return. > > > Source/WebCore/bindings/v8/V8GCController.cpp:526 > > + const int longIdlePauseInMs = 1000; > > longIdlePauseInMs -> longIdlePauseInMS > > > Source/WebCore/bindings/v8/V8GCController.h:79 > > + static void hintForGCIfNecessary(); > > Can we think of a better name for this function? Perhaps collectGarbageIfNecessary? Done.
Kentaro Hara
Comment 4 2012-08-13 18:32:29 PDT
Committed r125491: <http://trac.webkit.org/changeset/125491>
Note You need to log in before you can comment on or make changes to this bug.