We can move hintForGCIfNecessary() from V8Proxy.h to V8GCController.h.
Created attachment 157975 [details] Patch
Comment on attachment 157975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157975&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:525 > + if (data->shouldCollectGarbageSoon()) { Prefer early return. > Source/WebCore/bindings/v8/V8GCController.cpp:526 > + const int longIdlePauseInMs = 1000; longIdlePauseInMs -> longIdlePauseInMS > Source/WebCore/bindings/v8/V8GCController.h:79 > + static void hintForGCIfNecessary(); Can we think of a better name for this function? Perhaps collectGarbageIfNecessary?
(In reply to comment #2) > > Source/WebCore/bindings/v8/V8GCController.cpp:525 > > + if (data->shouldCollectGarbageSoon()) { > > Prefer early return. > > > Source/WebCore/bindings/v8/V8GCController.cpp:526 > > + const int longIdlePauseInMs = 1000; > > longIdlePauseInMs -> longIdlePauseInMS > > > Source/WebCore/bindings/v8/V8GCController.h:79 > > + static void hintForGCIfNecessary(); > > Can we think of a better name for this function? Perhaps collectGarbageIfNecessary? Done.
Committed r125491: <http://trac.webkit.org/changeset/125491>