Bug 93825 - [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
Summary: [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks: 42332
  Show dependency tree / graph
 
Reported: 2012-08-13 05:03 PDT by Mikhail Pozdnyakov
Modified: 2012-08-13 07:20 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.77 KB, patch)
2012-08-13 05:08 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-08-13 05:03:58 PDT 
void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo)
{
    static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFinishLoadForResource(page, frame, identifier, error);
}

should be

void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo)
{
    static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFailLoadForResource(page, frame, identifier, error);
}
Comment 1 Mikhail Pozdnyakov 2012-08-13 05:08:54 PDT 
Created attachment 157965 [details]
patch
Comment 2 Chris Dumez 2012-08-13 05:11:50 PDT 
Comment on attachment 157965 [details]
patch

LGTM.
Comment 3 Grzegorz Czajkowski 2012-08-13 06:36:21 PDT 
Comment on attachment 157965 [details]
patch

Nice catch.
Comment 4 WebKit Review Bot 2012-08-13 07:20:07 PDT 
Comment on attachment 157965 [details]
patch

Clearing flags on attachment: 157965

Committed r125418: <http://trac.webkit.org/changeset/125418>
Comment 5 WebKit Review Bot 2012-08-13 07:20:11 PDT 
All reviewed patches have been landed.  Closing bug.