Bug 93825 – [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Mikhail Pozdnyakov]

void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo)
{
    static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFinishLoadForResource(page, frame, identifier, error);
}

should be

void InjectedBundlePage::didFailLoadForResource(WKBundlePageRef page, WKBundleFrameRef frame, uint64_t identifier, WKErrorRef error, const void* clientInfo)
{
    static_cast<InjectedBundlePage*>(const_cast<void*>(clientInfo))->didFailLoadForResource(page, frame, identifier, error);
}

[Mikhail Pozdnyakov]

Created attachment 157965 [details]
patch

[Chris Dumez]

Comment on attachment 157965 [details]
patch

LGTM.

[Grzegorz Czajkowski]

Comment on attachment 157965 [details]
patch

Nice catch.

[WebKit Review Bot]

Comment on attachment 157965 [details]
patch

Clearing flags on attachment: 157965

Committed r125418: <http://trac.webkit.org/changeset/125418>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.