Bug 93815 – [EFL][WK2] Skip inspector tests that hit assertion in WebCore::SuspendableTimer::resume()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Several inspector test cases are flaky and sometimes hit an assertion in WebCore::SuspendableTimer::resume():

crash log for WebProcess (pid <unknown>):
STDOUT: <empty>
STDERR: ASSERTION FAILED: m_suspended
STDERR: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/Source/WebCore/page/SuspendableTimer.cpp(76) : virtual void WebCore::SuspendableTimer::resume()
STDERR: 1   0x7f4d7fef80cf WebCore::SuspendableTimer::resume()
STDERR: 2   0x7f4d7fa85345 WebCore::ScriptExecutionContext::resumeActiveDOMObjects()
STDERR: 3   0x7f4d7f9be004 WebCore::Document::resumeActiveDOMObjects()
STDERR: 4   0x7f4d804622f5 WebCore::PageScriptDebugServer::setJavaScriptPaused(WebCore::Frame*, bool)
STDERR: 5   0x7f4d804621c5 WebCore::PageScriptDebugServer::setJavaScriptPaused(WebCore::Page*, bool)
STDERR: 6   0x7f4d804620e7 WebCore::PageScriptDebugServer::setJavaScriptPaused(WebCore::PageGroup const&, bool)
STDERR: 7   0x7f4d80461fd2 WebCore::PageScriptDebugServer::didContinue(JSC::JSGlobalObject*)
STDERR: 8   0x7f4d80476982 WebCore::ScriptDebugServer::pauseIfNeeded(JSC::JSGlobalObject*)
STDERR: 9   0x7f4d804767ab WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded(JSC::DebuggerCallFrame const&, long, int, int)
STDERR: 10  0x7f4d80476cf2 WebCore::ScriptDebugServer::didReachBreakpoint(JSC::DebuggerCallFrame const&, long, int, int)
STDERR: 11  0x7f4d7a8a593e JSC::Interpreter::debug(JSC::ExecState*, JSC::DebugHookID, int, int, int)
STDERR: 12  0x7f4d7a8d8c86
STDERR: 13  0x7f4d7a8cedc0
STDERR: 14  0x7fff21a4f8f0
STDERR: LEAK: 1 WebPageProxy
STDERR: LEAK: 1 WebContext

The issue seems to be tracked by Bug 35220.

[Chris Dumez]

Created attachment 157954 [details]
Patch

Could someone please cq+ ?

[Chris Dumez]

Created attachment 157959 [details]
Patch

[WebKit Review Bot]

Comment on attachment 157959 [details]
Patch

Clearing flags on attachment: 157959

Committed r125409: <http://trac.webkit.org/changeset/125409>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.