Bug 93802 - Share common code between calendar picker and color suggestion picker
Summary: Share common code between calendar picker and color suggestion picker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-13 01:29 PDT by Keishi Hattori
Modified: 2012-08-14 20:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (131.77 KB, patch)
2012-08-13 01:36 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-02 (376.65 KB, application/zip)
2012-08-13 05:19 PDT, WebKit Review Bot
no flags Details
Patch (21.43 KB, patch)
2012-08-14 07:24 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-03 (396.52 KB, application/zip)
2012-08-14 08:03 PDT, WebKit Review Bot
no flags Details
Patch (20.96 KB, patch)
2012-08-14 19:25 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-08-13 01:29:16 PDT
Share common code between calendar picker and color suggestion picker
Comment 1 Keishi Hattori 2012-08-13 01:36:29 PDT
Created attachment 157939 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-13 05:19:16 PDT
Comment on attachment 157939 [details]
Patch

Attachment 157939 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13481744

New failing tests:
platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
Comment 3 WebKit Review Bot 2012-08-13 05:19:20 PDT
Created attachment 157967 [details]
Archive of layout-test-results from gce-cr-linux-02

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-02  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Kent Tamura 2012-08-13 18:23:47 PDT
Comment on attachment 157939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=157939&action=review

> Source/WebCore/ChangeLog:8
> +        Moved common code between calandarPicker and colorSuggestionPicker into pickerCommon.{js,css}

I recommend not addressing two things in one patch.  This patch can be split into 1. Move files to Resources/pagepopup/ and 2. Sharing common code.

> Source/WebCore/ChangeLog:12
> +        * Resources/pagepopup/calendarPicker.css: Renamed from Source/WebCore/Resources/calendarPicker.css.

Probably Resources/pagepopups/ is better?

> Source/WebCore/ChangeLog:25
> +

We had better update ManualTests/forms/calendar-picker.html and color-suggestion-picker.html.
Comment 5 Keishi Hattori 2012-08-14 07:24:19 PDT
Created attachment 158322 [details]
Patch
Comment 6 WebKit Review Bot 2012-08-14 08:03:36 PDT
Comment on attachment 158322 [details]
Patch

Attachment 158322 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13504193

New failing tests:
platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance.html
platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance.html
platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html
platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html
Comment 7 WebKit Review Bot 2012-08-14 08:03:39 PDT
Created attachment 158331 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 8 Keishi Hattori 2012-08-14 19:25:29 PDT
Created attachment 158482 [details]
Patch
Comment 9 Kent Tamura 2012-08-14 20:06:38 PDT
Comment on attachment 158482 [details]
Patch

ok
Comment 10 WebKit Review Bot 2012-08-14 20:34:30 PDT
Comment on attachment 158482 [details]
Patch

Clearing flags on attachment: 158482

Committed r125641: <http://trac.webkit.org/changeset/125641>
Comment 11 WebKit Review Bot 2012-08-14 20:34:34 PDT
All reviewed patches have been landed.  Closing bug.