RESOLVED FIXED 93798
Implement absolutely positioned flex items 
https://bugs.webkit.org/show_bug.cgi?id=93798
Summary Implement absolutely positioned flex items
Tony Chang
Reported 2012-08-13 00:00:29 PDT
This has changed recently: http://dev.w3.org/csswg/css3-flexbox/#abspos-items If I read this properly, it's saying that absolutely positioned items are positioned relative to the flex line it is on. I think the current code is using placeholders in the flex line.
Attachments
Patch (80.51 KB, patch)
2012-09-20 11:29 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (81.62 KB, patch)
2012-09-20 11:56 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-09-20 11:29:00 PDT
Created attachment 164954 [details] Patch
Ojan Vafai
Comment 2 2012-09-20 11:46:42 PDT
Comment on attachment 164954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review > Source/WebCore/rendering/RenderFlexibleBox.cpp:962 > +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const Nit: could make this a static and not need to add it to the header.
Build Bot
Comment 3 2012-09-20 11:48:13 PDT
Comment on attachment 164954 [details] Patch Attachment 164954 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13958259
Tony Chang
Comment 4 2012-09-20 11:56:31 PDT
Created attachment 164958 [details] Patch for landing
Tony Chang
Comment 5 2012-09-20 11:56:49 PDT
Comment on attachment 164954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review >> Source/WebCore/rendering/RenderFlexibleBox.cpp:962 >> +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const > > Nit: could make this a static and not need to add it to the header. I considered that, but that involves making OrderedFlexItemList non-private, which would still touch the header and seems worse (only RenderFlexbox should be using this type).
Ojan Vafai
Comment 6 2012-09-20 11:58:18 PDT
Comment on attachment 164954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164954&action=review >>> Source/WebCore/rendering/RenderFlexibleBox.cpp:962 >>> +size_t RenderFlexibleBox::numberOfInFlowPositionedChildren(const OrderedFlexItemList& children) const >> >> Nit: could make this a static and not need to add it to the header. > > I considered that, but that involves making OrderedFlexItemList non-private, which would still touch the header and seems worse (only RenderFlexbox should be using this type). Ah, right. NM.
WebKit Review Bot
Comment 7 2012-09-20 12:29:31 PDT
Comment on attachment 164958 [details] Patch for landing Clearing flags on attachment: 164958 Committed r129154: <http://trac.webkit.org/changeset/129154>
WebKit Review Bot
Comment 8 2012-09-20 12:29:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.