Bug 93791 – Tick marks don't match thumb when applying paddin or border to input type=range

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

Tick marks don't match thumb when styling input type=range

[Kent Tamura]

(In reply to comment #0)
> Tick marks don't match thumb when styling input type=range

What style? You should add information to reproduce the bug.

[Keishi Hattori]

Created attachment 158190 [details]
Test case

[Keishi Hattori]

Created attachment 158191 [details]
Test case screen shot

Applying padding or border makes the tracking element smaller.

[Keishi Hattori]

Created attachment 160328 [details]
Patch

[Kent Tamura]

Comment on attachment 160328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=160328&action=review

> Source/WebCore/rendering/RenderTheme.cpp:1012
> +        trackBounds = trackRenderer->absoluteBoundingBoxRectIgnoringTransforms();

We had better add a comment why IngoringTransforms is ok.

BTW, do we have a test for a transformed <input type=range> with tick marks?

> LayoutTests/ChangeLog:12
> +        * platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.

We had better mention a bug of track rendering with padding.

[WebKit Review Bot]

Comment on attachment 160328 [details]
Patch

Attachment 160328 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13595036

New failing tests:
fast/forms/datalist/input-appearance-range-with-datalist.html
fast/forms/datalist/input-appearance-range-with-padding-with-datalist.html
fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html

[WebKit Review Bot]

Created attachment 160347 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Keishi Hattori]

Created attachment 160356 [details]
Patch

[Keishi Hattori]

(In reply to comment #5)
> (From update of attachment 160328 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=160328&action=review
> 
> > Source/WebCore/rendering/RenderTheme.cpp:1012
> > +        trackBounds = trackRenderer->absoluteBoundingBoxRectIgnoringTransforms();
> 
> We had better add a comment why IngoringTransforms is ok.
> 
> BTW, do we have a test for a transformed <input type=range> with tick marks?
I had not tested with transforms.

> > LayoutTests/ChangeLog:12
> > +        * platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
> 
> We had better mention a bug of track rendering with padding.
I'm not sure what you meant. Should I add a description linking to this bug to the test input-appearance-range-with-padding-with-datalist.html?

[Keishi Hattori]

Created attachment 160357 [details]
Works with transforms and added description to test.

[Kent Tamura]

(In reply to comment #9)
> > > +        * platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
> > 
> > We had better mention a bug of track rendering with padding.
> I'm not sure what you meant. Should I add a description linking to this bug to the test input-appearance-range-with-padding-with-datalist.html?

I meant we had a bug that paintSliderTrack() didn't take account of paddings.
e.g. Sliders in this test have min=0 max=100, also they have tick marks at 0, 100, and so on. However Slider tracks don't start at the 0 tick mark and don't end at the 100 tick mark.

[Keishi Hattori]

Created attachment 160363 [details]
Added mention to Bug 94915 in ChangeLog and added TestExpectation entries

[Kent Tamura]

Comment on attachment 160363 [details]
Added mention to Bug 94915 in ChangeLog and added TestExpectation entries

ok

[WebKit Review Bot]

Comment on attachment 160363 [details]
Added mention to Bug 94915 in ChangeLog and added TestExpectation entries

Attachment 160363 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13593141

New failing tests:
fast/forms/datalist/input-appearance-range-with-datalist-zoomed.html
fast/forms/datalist/input-appearance-range-with-transform.html
fast/forms/datalist/input-appearance-range-with-datalist.html

[WebKit Review Bot]

Created attachment 160394 [details]
Archive of layout-test-results from gce-cr-linux-08

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-08  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Keishi Hattori]

Created attachment 160651 [details]
Patch

[Keishi Hattori]

Created attachment 160693 [details]
Patch

[WebKit Review Bot]

Comment on attachment 160693 [details]
Patch

Rejecting attachment 160693 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13660101

[Keishi Hattori]

Created attachment 161444 [details]
Patch

[Keishi Hattori]

Created attachment 161445 [details]
Patch

[WebKit Review Bot]

Comment on attachment 161445 [details]
Patch

Clearing flags on attachment: 161445

Committed r127140: <http://trac.webkit.org/changeset/127140>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.