Bug 93776 - CSSComputedStyleDeclaration::cssText() should use StringBuilder
Summary: CSSComputedStyleDeclaration::cssText() should use StringBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-12 00:36 PDT by Benjamin Poulain
Modified: 2012-08-12 11:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2012-08-12 00:43 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (2.36 KB, patch)
2012-08-12 01:03 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-12 00:36:02 PDT 
String::append() is very inefficient when use like that.
Comment 1 Benjamin Poulain 2012-08-12 00:43:53 PDT 
Created attachment 157891 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-12 00:48:14 PDT 
Comment on attachment 157891 [details]
Patch

Attachment 157891 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13480440
Comment 3 Benjamin Poulain 2012-08-12 01:03:12 PDT 
Created attachment 157892 [details]
Patch
Comment 4 Eric Seidel (no email) 2012-08-12 02:38:30 PDT 
Comment on attachment 157892 [details]
Patch

Yup.  Do we have any microbenchmarks to show the speed win?
Comment 5 WebKit Review Bot 2012-08-12 03:37:30 PDT 
Comment on attachment 157892 [details]
Patch

Clearing flags on attachment: 157892

Committed r125367: <http://trac.webkit.org/changeset/125367>
Comment 6 WebKit Review Bot 2012-08-12 03:37:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Benjamin Poulain 2012-08-12 11:54:41 PDT 
> Yup.  Do we have any microbenchmarks to show the speed win?

Here is what I used to get the numbers: http://jsperf.com/csscomputedstyledeclaration-csstext