Bug 93766 – r125351 exposes layout bugs where positioned objects, percent height descendants not cleared from their ancestors

• Status: NEW
• Component: Layout and Rendering

[Eric Carlson]

The following tests are crashing on the Mac bots as a result of r125351 <http://trac.webkit.org/changeset/125351>:

    fast/harness/results.html
    fast/multicol/span/positioned-objects-not-removed-crash.html
    fast/events/tabindex-focus-blur-all.html
    fast/block/positioning/relayout-nested-positioned-elements-crash-2.html
    editing/selection/move-left-right.html
    editing/selection/home-end.html

[Abhishek Arya]

see my c#6 in https://bugs.webkit.org/show_bug.cgi?id=89848.
Also, wanted a way to assert/debug only code in cases while calling remove descendant object that if the container it is removing from is not in the direct ancestors. that means we have a functional layout bug to fix.

----
We are glad to hit this so that we know of layout bugs where positioned objects were not cleared properly.
We shouldn't roll out this change since it actually helps to clear those positioned objects and prevent crashes. We just need to fix these layout bugs eventually and re-add the awesome assert back.

Disabled assert for now in http://trac.webkit.org/changeset/125353. the bots should be happy soon.

This is a good list of test failing in areas of fullscreen, multi-column layout, etc.
http://build.webkit.org/results/GTK%20Linux%2064-bit%20Debug/r125351%20(35524)/results.html

We can use this bug for tracking these layout bugs.

[Levi Weintraub]

Thanks for handling this quickly Abhishek! Awesome to have this list handy now :)

[Eric Carlson]

(In reply to comment #2)
> Thanks for handling this quickly Abhishek! Awesome to have this list handy now :)

+1, thanks inferno!