RESOLVED FIXED 93759
[chromium] FPS HUD bitmap contains random noise on the mac 
https://bugs.webkit.org/show_bug.cgi?id=93759
Summary [chromium] FPS HUD bitmap contains random noise on the mac
Vangelis Kokkevis
Reported 2012-08-10 19:48:40 PDT
This is a result of not clearing the canvas used by the HUD before drawing into it.
Attachments
Patch (2.81 KB, patch)
2012-08-10 19:53 PDT, Vangelis Kokkevis 		enne: review+
enne: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2012-08-10 19:53:48 PDT
Created attachment 157853 [details] Patch
Adrienne Walker
Comment 2 2012-08-12 12:48:09 PDT
Comment on attachment 157853 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=157853&action=review R=me, with one robustness suggestion. > Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:99 > + if (canvasSize.fWidth != bounds().width() || canvasSize.fHeight != bounds().height()) If bounds() are empty the first time through this function, it'll crash on a null m_hudCanvas below. Maybe add a || !m_hudCanvas for safety?
Vangelis Kokkevis
Comment 3 2012-08-13 13:48:54 PDT
Committed r125445: <http://trac.webkit.org/changeset/125445>
Note You need to log in before you can comment on or make changes to this bug.