Bug 93739 - REGRESSION(r125310): The DEPS roll broke Android. One does not simply break Android. (Requested by fmalita_ on #webkit).
Summary: REGRESSION(r125310): The DEPS roll broke Android. One does not simply break A...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 13:25 PDT by WebKit Review Bot
Modified: 2012-08-10 14:53 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r125310 (1.13 KB, patch)
2012-08-10 13:25 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-08-10 13:25:02 PDT
http://trac.webkit.org/changeset/125310 broke the build:
The DEPS roll broke Android. One does not simply break Android. (Requested by fmalita_ on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-08-10 13:25:32 PDT
Created attachment 157799 [details]
ROLLOUT of r125310

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Florin Malita 2012-08-10 13:30:55 PDT
Comment on attachment 157799 [details]
ROLLOUT of r125310

Clearing flags on attachment: 157799

Committed r125323: <http://trac.webkit.org/changeset/125323>
Comment 3 Florin Malita 2012-08-10 13:30:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 James Robinson 2012-08-10 14:47:02 PDT
Uh sorry, you can't revert a DEPS roll.  You need to fix it and roll forward.  Stopping is not an option!
Comment 5 Florin Malita 2012-08-10 14:53:38 PDT
Duly noted.

(the intent was to have it fixed without holding the WK bots red, then roll).