Bug 93737 - Improved RuleData packing on some 32-bit platforms
Summary: Improved RuleData packing on some 32-bit platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Florin Malita
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-10 12:43 PDT by Florin Malita
Modified: 2012-08-10 15:42 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.64 KB, patch)
2012-08-10 12:47 PDT, Florin Malita 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Florin Malita 2012-08-10 12:43:18 PDT 
Certain 32-bit platforms use an 8-byte alignment for uint64_t (as exposed by the build breakage after http://trac.webkit.org/changeset/125294).

To avoid wasting 4 bytes per object due to alignment, we can use two naturally-aligning unsigned integers instead.
Comment 1 Florin Malita 2012-08-10 12:47:27 PDT 
Created attachment 157795 [details]
Patch
Comment 2 Andreas Kling 2012-08-10 14:08:02 PDT 
Comment on attachment 157795 [details]
Patch

r=me, thanks for the fix!
Comment 3 WebKit Review Bot 2012-08-10 15:42:07 PDT 
Comment on attachment 157795 [details]
Patch

Clearing flags on attachment: 157795

Committed r125333: <http://trac.webkit.org/changeset/125333>
Comment 4 WebKit Review Bot 2012-08-10 15:42:12 PDT 
All reviewed patches have been landed.  Closing bug.