Bug 93736 - webarchive/ignore-noscript-if-scripting.html expected results should use .webarchive extension
Summary: webarchive/ignore-noscript-if-scripting.html expected results should use .web...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-08-10 12:36 PDT by Jon Lee
Modified: 2012-08-11 12:42 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.41 KB, patch)
2012-08-10 12:40 PDT, Jon Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2012-08-10 12:36:22 PDT
Because the test uses dumpDOMAsWebArchive(), the expected results extension should be .webarchive instead of .txt.
Comment 1 Radar WebKit Bug Importer 2012-08-10 12:36:45 PDT
<rdar://problem/12077654>
Comment 2 Jon Lee 2012-08-10 12:40:09 PDT
Created attachment 157793 [details]
Patch
Comment 3 Eric Seidel (no email) 2012-08-11 02:39:05 PDT
I assume run-webkit-tests plays nice with .webarchive files?
Comment 4 Dirk Pranke 2012-08-11 11:34:16 PDT
It did the last time I checked.
Comment 5 Jon Lee 2012-08-11 12:07:07 PDT
The rest of that directory uses the .webarchive extension instead of the .txt extension. And yes rwt works with those files.
Comment 6 WebKit Review Bot 2012-08-11 12:41:59 PDT
Comment on attachment 157793 [details]
Patch

Clearing flags on attachment: 157793

Committed r125354: <http://trac.webkit.org/changeset/125354>
Comment 7 WebKit Review Bot 2012-08-11 12:42:03 PDT
All reviewed patches have been landed.  Closing bug.