Bug 93734 – [chromium] Remove targetSurface pointer from CCRenderPass

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dana Jansens]

[chromium] Remove targetSurface pointer from CCRenderPass

[Dana Jansens]

Created attachment 157782 [details]
Patch

[Adrienne Walker]

Comment on attachment 157782 [details]
Patch

I suspect that this changed once the HUD became a layer, but are the debug rects now one frame behind?

[Dana Jansens]

(In reply to comment #2)
> (From update of attachment 157782 [details])
> I suspect that this changed once the HUD became a layer, but are the debug rects now one frame behind?

Are you referring to the ordering change here? It seems that they would just never have any rects for surface damage, since it was being cleared just before it was being saved. Or are you referring to behaviour you're seeing in the HUD?

[Adrienne Walker]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 157782 [details] [details])
> > I suspect that this changed once the HUD became a layer, but are the debug rects now one frame behind?
> 
> Are you referring to the ordering change here? It seems that they would just never have any rects for surface damage, since it was being cleared just before it was being saved. Or are you referring to behaviour you're seeing in the HUD?

Just trying to understand.  It's a good thing the hud is so well-tested, sad trombone noise.

This is what I understand from reading the code:

Pre-HUD layer: debug rects saved, damage cleared, hud drawn
Post-HUD layer: hud layer drawn, damage cleared, debug rects saved
This patch: hud layer drawn, debug rects saved, damage cleared

Or:

Pre-HUD layer: debug rects for current frame drawn on current frame
Post-HUD layer: debug rects for previous frame drawn on current frame, damage never drawn
This patch: debug rects for previous frame drawn on current frame

[Dana Jansens]

Oh I see.

Here's what I see pre-HUD-layer:
drawFrame
drawHud
clearDamage
saveRects

So, busted, and showing rects from the previous frame.

Before this patch, I see:
drawFrame (including Hud)
clearDamage
saveRects

After this patch, I see:
drawFrame (including Hud)
saveRects
clearDamage

Maybe we should be saving rects before drawFrame, I'll open a bug and we can discuss with shawn.

[Adrienne Walker]

Comment on attachment 157782 [details]
Patch

R=me.  With respect to the HUD bug, this patch is still a strict improvement, so no reason not to land it.

[WebKit Review Bot]

Comment on attachment 157782 [details]
Patch

Clearing flags on attachment: 157782

Committed r125325: <http://trac.webkit.org/changeset/125325>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.