Bug 93728 - NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
Summary: NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xianzhu Wang
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-08-10 10:15 PDT by Xianzhu Wang
Modified: 2012-08-10 12:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2012-08-10 10:22 PDT, Xianzhu Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xianzhu Wang 2012-08-10 10:15:49 PDT
If DRT running with --encode-binary crashes just before it dump pixels, block.content might be set to None (returned from self._server_process.read_stdout() at driver.py:421), then block.decode_content() will cause crash of NRWT in base64.b64decode() because self.content is None.
Comment 1 Xianzhu Wang 2012-08-10 10:22:34 PDT
Created attachment 157756 [details]
Patch
Comment 2 Xianzhu Wang 2012-08-10 11:47:41 PDT
Comment on attachment 157756 [details]
Patch

Sorry for the wrong component :)
Comment 3 WebKit Review Bot 2012-08-10 12:49:37 PDT
Comment on attachment 157756 [details]
Patch

Clearing flags on attachment: 157756

Committed r125316: <http://trac.webkit.org/changeset/125316>
Comment 4 WebKit Review Bot 2012-08-10 12:49:41 PDT
All reviewed patches have been landed.  Closing bug.